Re: [Qemu-devel] [PATCH] pci_host: Drop write-only address_space field

2013-03-01 Thread Andreas Färber
Am 01.03.2013 19:50, schrieb Peter Maydell: > On 1 March 2013 18:33, Andreas Färber wrote: >> Am 01.03.2013 17:57, schrieb Peter Maydell: >>> The address_space field of PCIHostState was only ever written, never used. >>> Drop it completely. >>> >>> Signed-off-by: Peter Maydell >> >> Reviewed-by:

Re: [Qemu-devel] [PATCH] pci_host: Drop write-only address_space field

2013-03-01 Thread Peter Maydell
On 1 March 2013 18:33, Andreas Färber wrote: > Am 01.03.2013 17:57, schrieb Peter Maydell: >> The address_space field of PCIHostState was only ever written, never used. >> Drop it completely. >> >> Signed-off-by: Peter Maydell > > Reviewed-by: Andreas Färber Incidentally I suspect you could if

Re: [Qemu-devel] [PATCH] pci_host: Drop write-only address_space field

2013-03-01 Thread Andreas Färber
Am 01.03.2013 17:57, schrieb Peter Maydell: > The address_space field of PCIHostState was only ever written, never used. > Drop it completely. > > Signed-off-by: Peter Maydell Reviewed-by: Andreas Färber Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Haw

[Qemu-devel] [PATCH] pci_host: Drop write-only address_space field

2013-03-01 Thread Peter Maydell
The address_space field of PCIHostState was only ever written, never used. Drop it completely. Signed-off-by: Peter Maydell --- Noticed this when looking at converting versatile_pci to be a subclass of pci_host; it's nice to be able to drop the ugly fishing around in the object struct that the tw