Re: [Qemu-devel] [PATCH] pcie: remove duplicate assertion

2017-01-10 Thread Cao jin
On 01/10/2017 06:37 AM, Michael S. Tsirkin wrote: > On Fri, Dec 23, 2016 at 10:16:30AM +0800, Cao jin wrote: >> "size >= 8" connote "size > 0" >> >> Signed-off-by: Cao jin > > Isn't the point to check for overflows? > Make sense. If it is intended to check

Re: [Qemu-devel] [PATCH] pcie: remove duplicate assertion

2017-01-09 Thread Michael S. Tsirkin
On Fri, Dec 23, 2016 at 10:16:30AM +0800, Cao jin wrote: > "size >= 8" connote "size > 0" > > Signed-off-by: Cao jin Isn't the point to check for overflows? > --- > hw/pci/pcie.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c >

[Qemu-devel] [PATCH] pcie: remove duplicate assertion

2016-12-22 Thread Cao jin
"size >= 8" connote "size > 0" Signed-off-by: Cao jin --- hw/pci/pcie.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c index 39b10b852d91..f864c5cd5458 100644 --- a/hw/pci/pcie.c +++ b/hw/pci/pcie.c @@ -668,7 +668,6 @@ void