Re: [Qemu-devel] [PATCH] ppc: Include vga cirrus card into the compiling process

On Tue, Jul 03, 2018 at 10:20:41AM -0500, Eric Blake wrote: > On 07/02/2018 11:41 PM, David Gibson wrote: > > > That's a good point. At the moment there's really nothing there about > > testing your patch before submission, which is a bit of an ommission. > > > > [1] covers a bunch of ways that

Re: [Qemu-devel] [PATCH] ppc: Include vga cirrus card into the compiling process

On 07/02/2018 11:41 PM, David Gibson wrote: That's a good point. At the moment there's really nothing there about testing your patch before submission, which is a bit of an ommission. [1] covers a bunch of ways that qemu can be tested, but doesn't give much idea about priority. +eblake, you

Re: [Qemu-devel] [PATCH] ppc: Include vga cirrus card into the compiling process

On Mon, Jul 02, 2018 at 09:42:49AM +0200, Sebastian Bauer wrote: > Am 2018-07-02 07:22, schrieb David Gibson: > > And now unapplied, since it breaks make check all over the place for > > ppc64-softmmu. > > > > Please folks, running an all-targets make check is really the > > *minimum* bar for

Re: [Qemu-devel] [PATCH] ppc: Include vga cirrus card into the compiling process

Am 2018-07-02 07:22, schrieb David Gibson: And now unapplied, since it breaks make check all over the place for ppc64-softmmu. Please folks, running an all-targets make check is really the *minimum* bar for testing before posting a patch for inclusion. Okay, will do next time. Sorry for the

Re: [Qemu-devel] [PATCH] ppc: Include vga cirrus card into the compiling process

On Mon, Jul 02, 2018 at 02:02:39PM +1000, David Gibson wrote: > On Sat, Jun 30, 2018 at 01:29:05PM +0200, BALATON Zoltan wrote: > 11;rgb://> On Sat, 30 Jun 2018, David Gibson wrote: > > > On Fri, Jun 29, 2018 at 08:06:10PM +0200, Sebastian Bauer wrote: > > > > Hi, > > > > > > > > Am

Re: [Qemu-devel] [PATCH] ppc: Include vga cirrus card into the compiling process

On Sat, Jun 30, 2018 at 01:29:05PM +0200, BALATON Zoltan wrote: 11;rgb://> On Sat, 30 Jun 2018, David Gibson wrote: > > On Fri, Jun 29, 2018 at 08:06:10PM +0200, Sebastian Bauer wrote: > > > Hi, > > > > > > Am 2018-06-19 06:36, schrieb David Gibson: > > > > Ok. However, your patch

Re: [Qemu-devel] [PATCH] ppc: Include vga cirrus card into the compiling process

On Sat, 30 Jun 2018, David Gibson wrote: On Fri, Jun 29, 2018 at 08:06:10PM +0200, Sebastian Bauer wrote: Hi, Am 2018-06-19 06:36, schrieb David Gibson: Ok. However, your patch doesn't apply against the ppc-for-3.0 tree. It looks like you've made it against a tree including some of BALATON

Re: [Qemu-devel] [PATCH] ppc: Include vga cirrus card into the compiling process

On Fri, Jun 29, 2018 at 08:06:10PM +0200, Sebastian Bauer wrote: > Hi, > > Am 2018-06-19 06:36, schrieb David Gibson: > > Ok. However, your patch doesn't apply against the ppc-for-3.0 tree. > > It looks like you've made it against a tree including some of BALATON > > Zoltan's proposed but not

Re: [Qemu-devel] [PATCH] ppc: Include vga cirrus card into the compiling process

Hi, Am 2018-06-19 06:36, schrieb David Gibson: Ok. However, your patch doesn't apply against the ppc-for-3.0 tree. It looks like you've made it against a tree including some of BALATON Zoltan's proposed but not yet merged patches. Please make sure your patches are against the current

Re: [Qemu-devel] [PATCH] ppc: Include vga cirrus card into the compiling process

Hello David, Am 2018-06-19 06:36, schrieb David Gibson: Ok. However, your patch doesn't apply against the ppc-for-3.0 tree. It looks like you've made it against a tree including some of BALATON Zoltan's proposed but not yet merged patches. Please make sure your patches are against the current

Re: [Qemu-devel] [PATCH] ppc: Include vga cirrus card into the compiling process

On 19.06.2018 01:55, David Gibson wrote: > On Mon, Jun 18, 2018 at 11:56:01PM +0200, Sebastian Bauer wrote: >> Drivers for this card exists on PPC-based AmigaOS guests so it is useful to >> allow users to emulate the graphics card for PPC machines. >> >> Signed-off-by: Sebastian Bauer > > Have

Re: [Qemu-devel] [PATCH] ppc: Include vga cirrus card into the compiling process

On Tue, Jun 19, 2018 at 06:32:55AM +0200, Sebastian Bauer wrote: > Am 2018-06-19 01:55, schrieb David Gibson: > > Have you checked the Cirrus VGA actually works on a ppc machine? > > Yes, it works for AmigaOS guests. Better than the sm501 for > instance. Ok. However, your patch doesn't apply

Re: [Qemu-devel] [PATCH] ppc: Include vga cirrus card into the compiling process

Am 2018-06-19 01:55, schrieb David Gibson: Have you checked the Cirrus VGA actually works on a ppc machine? Yes, it works for AmigaOS guests. Better than the sm501 for instance. Bye Sebastian

Re: [Qemu-devel] [PATCH] ppc: Include vga cirrus card into the compiling process

On Mon, Jun 18, 2018 at 11:56:01PM +0200, Sebastian Bauer wrote: > Drivers for this card exists on PPC-based AmigaOS guests so it is useful to > allow users to emulate the graphics card for PPC machines. > > Signed-off-by: Sebastian Bauer Have you checked the Cirrus VGA actually works on a ppc

[Qemu-devel] [PATCH] ppc: Include vga cirrus card into the compiling process

Drivers for this card exists on PPC-based AmigaOS guests so it is useful to allow users to emulate the graphics card for PPC machines. Signed-off-by: Sebastian Bauer --- default-configs/ppc-softmmu.mak | 1 + 1 file changed, 1 insertion(+) diff --git a/default-configs/ppc-softmmu.mak