Re: [Qemu-devel] [PATCH] ppc: do not use get_clock_realtime()

2014-12-04 Thread Tony Breeds
On Thu, Nov 27, 2014 at 06:00:38PM +0100, Paolo Bonzini wrote: > You're right. It's just that the API should be private to > qemu-timer.c, it is not meant for external usage---and it is messy > because get_clock_realtime() is for QEMU_CLOCK_HOST. Somehow this got horrendously lost. > In addition

Re: [Qemu-devel] [PATCH] ppc: do not use get_clock_realtime()

2014-11-27 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 27/11/2014 01:51, Tony Breeds wrote: > On Wed, Nov 26, 2014 at 03:01:01PM +0100, Paolo Bonzini wrote: >> Use the external qemu-timer API instead. > > Perhaps it's obvious but is it reasonable to expand on why you're > doign this in the commit me

Re: [Qemu-devel] [PATCH] ppc: do not use get_clock_realtime()

2014-11-26 Thread Tony Breeds
On Wed, Nov 26, 2014 at 03:01:01PM +0100, Paolo Bonzini wrote: > Use the external qemu-timer API instead. Perhaps it's obvious but is it reasonable to expand on why you're doign this in the commit message? Yours Tony. pgpbbAXtQoPFT.pgp Description: PGP signature

[Qemu-devel] [PATCH] ppc: do not use get_clock_realtime()

2014-11-26 Thread Paolo Bonzini
Use the external qemu-timer API instead. Cc: qemu-...@nongnu.org Signed-off-by: Paolo Bonzini --- hw/ppc/ppc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ppc/ppc.c b/hw/ppc/ppc.c index bec82cd..5ce565d 100644 --- a/hw/ppc/ppc.c +++ b/hw/ppc/ppc.c @@ -844,7 +844,7