Re: [Qemu-devel] [PATCH] ppc: virtex_ml507: QEMU_OPTION_dtb support for this machine.

2013-08-14 Thread Alexander Graf
On 13.08.2013, at 13:09, Efimov Vasily wrote: Signed-off-by: Efimov Vasily r...@ispras.ru Please provide a patch description :). --- hw/ppc/virtex_ml507.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/hw/ppc/virtex_ml507.c b/hw/ppc/virtex_ml507.c

Re: [Qemu-devel] [PATCH] ppc: virtex_ml507: QEMU_OPTION_dtb support for this machine.

2013-08-14 Thread Edgar E. Iglesias
On Wed, Aug 14, 2013 at 11:51:19AM +0200, Alexander Graf wrote: On 13.08.2013, at 13:09, Efimov Vasily wrote: Signed-off-by: Efimov Vasily r...@ispras.ru Please provide a patch description :). --- hw/ppc/virtex_ml507.c | 13 ++--- 1 file changed, 10 insertions(+), 3

Re: [Qemu-devel] [PATCH] ppc: virtex_ml507: QEMU_OPTION_dtb support for this machine.

2013-08-14 Thread Alexander Graf
On 14.08.2013, at 11:56, Edgar E. Iglesias wrote: On Wed, Aug 14, 2013 at 11:51:19AM +0200, Alexander Graf wrote: On 13.08.2013, at 13:09, Efimov Vasily wrote: Signed-off-by: Efimov Vasily r...@ispras.ru Please provide a patch description :). --- hw/ppc/virtex_ml507.c | 13

Re: [Qemu-devel] [PATCH] ppc: virtex_ml507: QEMU_OPTION_dtb support for this machine.

2013-08-14 Thread Felix Deichmann
2013/8/14 Alexander Graf ag...@suse.de: -void *fdt; +void *fdt = 0; This should be NULL. NULL doesn't have to be 0 according to C IIRC. The last statement is wrong here, NULL is always the same as 0 language-wise. Although the above code is always correct, some will consider it better

Re: [Qemu-devel] [PATCH] ppc: virtex_ml507: QEMU_OPTION_dtb support for this machine.

2013-08-14 Thread Alexander Graf
On 14.08.2013, at 12:34, Felix Deichmann wrote: 2013/8/14 Alexander Graf ag...@suse.de: -void *fdt; +void *fdt = 0; This should be NULL. NULL doesn't have to be 0 according to C IIRC. The last statement is wrong here, NULL is always the same as 0 language-wise. Although the

Re: [Qemu-devel] [PATCH] ppc: virtex_ml507: QEMU_OPTION_dtb support for this machine.

2013-08-14 Thread Edgar E. Iglesias
On Wed, Aug 14, 2013 at 12:03:34PM +0200, Alexander Graf wrote: On 14.08.2013, at 11:56, Edgar E. Iglesias wrote: On Wed, Aug 14, 2013 at 11:51:19AM +0200, Alexander Graf wrote: On 13.08.2013, at 13:09, Efimov Vasily wrote: Signed-off-by: Efimov Vasily r...@ispras.ru

Re: [Qemu-devel] [PATCH] ppc: virtex_ml507: QEMU_OPTION_dtb support for this machine.

2013-08-14 Thread Alexander Graf
On 14.08.2013, at 13:03, Edgar E. Iglesias wrote: On Wed, Aug 14, 2013 at 12:03:34PM +0200, Alexander Graf wrote: On 14.08.2013, at 11:56, Edgar E. Iglesias wrote: On Wed, Aug 14, 2013 at 11:51:19AM +0200, Alexander Graf wrote: On 13.08.2013, at 13:09, Efimov Vasily wrote:

Re: [Qemu-devel] [PATCH] ppc: virtex_ml507: QEMU_OPTION_dtb support for this machine.

2013-08-14 Thread Andreas Färber
Am 14.08.2013 13:03, schrieb Edgar E. Iglesias: On Wed, Aug 14, 2013 at 12:03:34PM +0200, Alexander Graf wrote: Then let's make the logic work like this: if (user provided -dtb) { if (load_dtb(user provided dtb)) { abort(); } } else { if (load_dtb(ppc.dtb)) { if

[Qemu-devel] [PATCH] ppc: virtex_ml507: QEMU_OPTION_dtb support for this machine.

2013-08-13 Thread Efimov Vasily
Signed-off-by: Efimov Vasily r...@ispras.ru --- hw/ppc/virtex_ml507.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/hw/ppc/virtex_ml507.c b/hw/ppc/virtex_ml507.c index 08e77fb..a00f709 100644 --- a/hw/ppc/virtex_ml507.c +++ b/hw/ppc/virtex_ml507.c @@