Re: [Qemu-devel] [PATCH] qapi/x86: add control registers to query-cpus

2013-01-30 Thread Peter Feiner
On Fri, Jan 25, 2013 at 8:08 AM, Andreas Färber wrote: > We just need to be aware that inspecting register values is one thing, > but that letting QMP qom-set arbitrary registers during runtime could > cause unpredictable issues. Checks on dev->realized could be added as > precaution (cf. qdev sta

Re: [Qemu-devel] [PATCH] qapi/x86: add control registers to query-cpus

2013-01-25 Thread Luiz Capitulino
On Fri, 25 Jan 2013 13:51:14 +0100 Andreas Färber wrote: > Am 25.01.2013 13:14, schrieb Luiz Capitulino: > > On Thu, 24 Jan 2013 13:12:08 -0500 > > Peter Feiner wrote: > > > >>> What about converting 'info registers' to QMP (ie. having > >>> query-cpu-registers)? > >> > >> We had thought about

Re: [Qemu-devel] [PATCH] qapi/x86: add control registers to query-cpus

2013-01-25 Thread Eduardo Habkost
On Fri, Jan 25, 2013 at 10:45:11AM -0200, Luiz Capitulino wrote: [...] > > >> The obvious suggestion is to add query-cpu-registers. I understand this > > >> has a > > >> few problems (see questions below), but I think the following incremental > > >> approach could work: > > >> > > >> 1. Add a CP

Re: [Qemu-devel] [PATCH] qapi/x86: add control registers to query-cpus

2013-01-25 Thread Andreas Färber
Am 25.01.2013 13:14, schrieb Luiz Capitulino: > On Thu, 24 Jan 2013 13:12:08 -0500 > Peter Feiner wrote: > >>> What about converting 'info registers' to QMP (ie. having >>> query-cpu-registers)? >> >> We had thought about it, but we decided to go with this lower hanging fruit >> because it provi

Re: [Qemu-devel] [PATCH] qapi/x86: add control registers to query-cpus

2013-01-25 Thread Andreas Färber
Am 25.01.2013 13:45, schrieb Luiz Capitulino: > On Fri, 25 Jan 2013 13:38:18 +0100 > Paolo Bonzini wrote: > >> Il 25/01/2013 13:34, Eduardo Habkost ha scritto: >>> We already have CPU QOM objects, we just need to add a >>> methods/properties so each per-architecture subclass will implement >>> wh

Re: [Qemu-devel] [PATCH] qapi/x86: add control registers to query-cpus

2013-01-25 Thread Luiz Capitulino
On Fri, 25 Jan 2013 13:38:18 +0100 Paolo Bonzini wrote: > Il 25/01/2013 13:34, Eduardo Habkost ha scritto: > > On Fri, Jan 25, 2013 at 10:14:43AM -0200, Luiz Capitulino wrote: > >> On Thu, 24 Jan 2013 13:12:08 -0500 > >> Peter Feiner wrote: > >> > What about converting 'info registers' to Q

Re: [Qemu-devel] [PATCH] qapi/x86: add control registers to query-cpus

2013-01-25 Thread Paolo Bonzini
Il 25/01/2013 13:34, Eduardo Habkost ha scritto: > On Fri, Jan 25, 2013 at 10:14:43AM -0200, Luiz Capitulino wrote: >> On Thu, 24 Jan 2013 13:12:08 -0500 >> Peter Feiner wrote: >> What about converting 'info registers' to QMP (ie. having query-cpu-registers)? >>> >>> We had thought abou

Re: [Qemu-devel] [PATCH] qapi/x86: add control registers to query-cpus

2013-01-25 Thread Eduardo Habkost
On Fri, Jan 25, 2013 at 10:14:43AM -0200, Luiz Capitulino wrote: > On Thu, 24 Jan 2013 13:12:08 -0500 > Peter Feiner wrote: > > > > What about converting 'info registers' to QMP (ie. having > > > query-cpu-registers)? > > > > We had thought about it, but we decided to go with this lower hanging

Re: [Qemu-devel] [PATCH] qapi/x86: add control registers to query-cpus

2013-01-25 Thread Luiz Capitulino
On Thu, 24 Jan 2013 13:12:08 -0500 Peter Feiner wrote: > > What about converting 'info registers' to QMP (ie. having > > query-cpu-registers)? > > We had thought about it, but we decided to go with this lower hanging fruit > because it provides immediately useful functionality at a low implemen

Re: [Qemu-devel] [PATCH] qapi/x86: add control registers to query-cpus

2013-01-24 Thread Peter Feiner
> What about converting 'info registers' to QMP (ie. having > query-cpu-registers)? We had thought about it, but we decided to go with this lower hanging fruit because it provides immediately useful functionality at a low implementation cost. It's harder (for us) to think of why would anyone want

Re: [Qemu-devel] [PATCH] qapi/x86: add control registers to query-cpus

2013-01-24 Thread Luiz Capitulino
On Wed, 23 Jan 2013 16:45:50 -0500 pe...@gridcentric.ca wrote: > From: Peter Feiner > > Adds control registers that govern virtual address translation to query-cpus. > > Given these registers and the guest's physical memory, which can be obtained > with dump-guest-memory, a client can perform v

Re: [Qemu-devel] [PATCH] qapi/x86: add control registers to query-cpus

2013-01-23 Thread Peter Feiner
On Wed, Jan 23, 2013 at 4:49 PM, Eric Blake wrote: > Might be worth mentioning that this field (and the others) was added in 1.4. Thanks Eric. I'll put that in V2.

Re: [Qemu-devel] [PATCH] qapi/x86: add control registers to query-cpus

2013-01-23 Thread Eric Blake
On 01/23/2013 02:45 PM, pe...@gridcentric.ca wrote: > From: Peter Feiner > > Adds control registers that govern virtual address translation to query-cpus. > > Given these registers and the guest's physical memory, which can be obtained > with dump-guest-memory, a client can perform virtual-to-ph

[Qemu-devel] [PATCH] qapi/x86: add control registers to query-cpus

2013-01-23 Thread peter
From: Peter Feiner Adds control registers that govern virtual address translation to query-cpus. Given these registers and the guest's physical memory, which can be obtained with dump-guest-memory, a client can perform virtual-to-physical translations. This is useful for debugging and introspect