Re: [Qemu-devel] [PATCH] qapi: generate space in c_type() to fix coding style

2014-04-25 Thread Markus Armbruster
Amos Kong ak...@redhat.com writes: On Tue, Apr 22, 2014 at 09:20:41AM +0200, Markus Armbruster wrote: Paolo Bonzini pbonz...@redhat.com writes: Il 18/04/2014 23:56, Amos Kong ha scritto: Currently we always add a space after c_type in mcgen(), there is some redundant space in generated

Re: [Qemu-devel] [PATCH] qapi: generate space in c_type() to fix coding style

2014-04-24 Thread Amos Kong
On Tue, Apr 22, 2014 at 09:20:41AM +0200, Markus Armbruster wrote: Paolo Bonzini pbonz...@redhat.com writes: Il 18/04/2014 23:56, Amos Kong ha scritto: Currently we always add a space after c_type in mcgen(), there is some redundant space in generated code. The space isn't needed for

Re: [Qemu-devel] [PATCH] qapi: generate space in c_type() to fix coding style

2014-04-22 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: Il 18/04/2014 23:56, Amos Kong ha scritto: Currently we always add a space after c_type in mcgen(), there is some redundant space in generated code. The space isn't needed for points by the coding style. char * value; ^

Re: [Qemu-devel] [PATCH] qapi: generate space in c_type() to fix coding style

2014-04-21 Thread Amos Kong
On Sat, Apr 19, 2014 at 03:16:52PM -0600, Eric Blake wrote: On 04/18/2014 09:56 PM, Amos Kong wrote: Currently we always add a space after c_type in mcgen(), there is some redundant space in generated code. The space isn't needed for points by the coding style. Second sentence is

Re: [Qemu-devel] [PATCH] qapi: generate space in c_type() to fix coding style

2014-04-19 Thread Paolo Bonzini
Il 18/04/2014 23:56, Amos Kong ha scritto: Currently we always add a space after c_type in mcgen(), there is some redundant space in generated code. The space isn't needed for points by the coding style. char * value; ^ qapi_free_NameInfo(NameInfo * obj)

Re: [Qemu-devel] [PATCH] qapi: generate space in c_type() to fix coding style

2014-04-19 Thread Eric Blake
On 04/18/2014 09:56 PM, Amos Kong wrote: Currently we always add a space after c_type in mcgen(), there is some redundant space in generated code. The space isn't needed for points by the coding style. Second sentence is awkward; maybe: Avoiding the space when appropriate makes us match the

[Qemu-devel] [PATCH] qapi: generate space in c_type() to fix coding style

2014-04-18 Thread Amos Kong
Currently we always add a space after c_type in mcgen(), there is some redundant space in generated code. The space isn't needed for points by the coding style. char * value; ^ qapi_free_NameInfo(NameInfo * obj) ^ It's fussy to add checking in each