Re: [Qemu-devel] [PATCH] qdev: Fix device_add bus assumptions

2013-04-22 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] qdev: Fix device_add bus assumptions

2013-04-22 Thread KONRAD Frédéric
On 22/04/2013 16:22, Andreas Färber wrote: Am 22.04.2013 16:15, schrieb KONRAD Frédéric: On 22/04/2013 16:02, Andreas Färber wrote: Hi Fred, Am 22.04.2013 15:54, schrieb KONRAD Frédéric: On 22/04/2013 15:27, Andreas Färber wrote: Am 22.04.2013 13:51, schrieb Libaiqing: When I use the c

Re: [Qemu-devel] [PATCH] qdev: Fix device_add bus assumptions

2013-04-22 Thread Andreas Färber
Am 22.04.2013 16:15, schrieb KONRAD Frédéric: > On 22/04/2013 16:02, Andreas Färber wrote: >> Hi Fred, >> >> Am 22.04.2013 15:54, schrieb KONRAD Frédéric: >>> On 22/04/2013 15:27, Andreas Färber wrote: Am 22.04.2013 13:51, schrieb Libaiqing: > When I use the config below,an error occur

Re: [Qemu-devel] [PATCH] qdev: Fix device_add bus assumptions

2013-04-22 Thread KONRAD Frédéric
Igor Mammedov Cc: ehabk...@redhat.com; qemu-devel@nongnu.org; arm...@redhat.com; anth...@codemonkey.ws; pbonz...@redhat.com; lcapitul...@redhat.com; Andreas Färber Subject: Re: [Qemu-devel] [PATCH] qdev: Fix device_add bus assumptions On Thu, 18 Apr 2013 10:41:56 +0200 Igor Mammedov wrote: [...] -

Re: [Qemu-devel] [PATCH] qdev: Fix device_add bus assumptions

2013-04-22 Thread Andreas Färber
ion... :) It would fix command line backwards compatibility but would be inconsistent then; I guess the former is more important here. Regards, Andreas > > Sorry for that, > Fred > >> >>> -Original Message- >>> From: qemu-devel-bounces+libaiqing=hu

Re: [Qemu-devel] [PATCH] qdev: Fix device_add bus assumptions

2013-04-22 Thread KONRAD Frédéric
edhat.com; lcapitul...@redhat.com; Andreas Färber Subject: Re: [Qemu-devel] [PATCH] qdev: Fix device_add bus assumptions On Thu, 18 Apr 2013 10:41:56 +0200 Igor Mammedov wrote: [...] -if (!bus) { -bus = sysbus_get_default(); -} - I've checked all direct childs of TYPE_DEVIC

Re: [Qemu-devel] [PATCH] qdev: Fix device_add bus assumptions

2013-04-22 Thread Andreas Färber
Am 18.04.2013 10:41, schrieb Igor Mammedov: > On Tue, 16 Apr 2013 03:50:21 +0200 > Andreas Färber wrote: > >> Drop an unreachable fallback bus assignment to SysBus. >> >> If no ,bus= is specified, only search busses recursively for bus type if >> the DeviceClass has a bus_type specified. Handle r

Re: [Qemu-devel] [PATCH] qdev: Fix device_add bus assumptions

2013-04-22 Thread Andreas Färber
...@nongnu.org > [mailto:qemu-devel-bounces+libaiqing=huawei@nongnu.org] On Behalf Of Igor > Mammedov > Sent: Thursday, April 18, 2013 5:02 PM > To: Igor Mammedov > Cc: ehabk...@redhat.com; qemu-devel@nongnu.org; arm...@redhat.com; > anth...@codemonkey.ws; pbonz...@r

Re: [Qemu-devel] [PATCH] qdev: Fix device_add bus assumptions

2013-04-22 Thread Libaiqing
ect: Re: [Qemu-devel] [PATCH] qdev: Fix device_add bus assumptions On Thu, 18 Apr 2013 10:41:56 +0200 Igor Mammedov wrote: [...] > > -if (!bus) { > > -bus = sysbus_get_default(); > > -} > > - > I've checked all direct childs of TYPE_DEVICE and th

Re: [Qemu-devel] [PATCH] qdev: Fix device_add bus assumptions

2013-04-18 Thread Igor Mammedov
On Thu, 18 Apr 2013 10:41:56 +0200 Igor Mammedov wrote: [...] > > -if (!bus) { > > -bus = sysbus_get_default(); > > -} > > - > I've checked all direct childs of TYPE_DEVICE and they all set k->bus_type, > with only one exception of TYPE_CPU. So it should be safe to remove fallback

Re: [Qemu-devel] [PATCH] qdev: Fix device_add bus assumptions

2013-04-18 Thread Igor Mammedov
On Tue, 16 Apr 2013 03:50:21 +0200 Andreas Färber wrote: > Drop an unreachable fallback bus assignment to SysBus. > > If no ,bus= is specified, only search busses recursively for bus type if > the DeviceClass has a bus_type specified. Handle resulting NULL cases. > > Signed-off-by: Andreas Färb

[Qemu-devel] [PATCH] qdev: Fix device_add bus assumptions

2013-04-15 Thread Andreas Färber
Drop an unreachable fallback bus assignment to SysBus. If no ,bus= is specified, only search busses recursively for bus type if the DeviceClass has a bus_type specified. Handle resulting NULL cases. Signed-off-by: Andreas Färber --- qdev-monitor.c | 16 1 file changed, 8 insert