Re: [Qemu-devel] [PATCH] qdev: Reject duplicate and anti-social device IDs

2010-06-08 Thread Markus Armbruster
Paul Brook writes: >> Paul Brook writes: >> >> Also require IDs to start with a letter to provide for possible future >> >> extensions. >> > >> > I'd go further than that, and require that user specified IDs match >> > [A-Za-z][A-Za-z0-9_-]* >> >> I talked with Dan (cc'ed) to make sure we don'

Re: [Qemu-devel] [PATCH] qdev: Reject duplicate and anti-social device IDs

2010-06-04 Thread Paul Brook
> Paul Brook writes: > >> Also require IDs to start with a letter to provide for possible future > >> extensions. > > > > I'd go further than that, and require that user specified IDs match > > [A-Za-z][A-Za-z0-9_-]* > > I talked with Dan (cc'ed) to make sure we don't trample on existing > libvi

Re: [Qemu-devel] [PATCH] qdev: Reject duplicate and anti-social device IDs

2010-06-04 Thread Markus Armbruster
Paul Brook writes: >> Also require IDs to start with a letter to provide for possible future >> extensions. > > I'd go further than that, and require that user specified IDs match > [A-Za-z][A-Za-z0-9_-]* I talked with Dan (cc'ed) to make sure we don't trample on existing libvirt usage without n

Re: [Qemu-devel] [PATCH] qdev: Reject duplicate and anti-social device IDs

2010-06-02 Thread Paul Brook
> Also require IDs to start with a letter to provide for possible future > extensions. I'd go further than that, and require that user specified IDs match [A-Za-z][A-Za-z0-9_-]* Paul

[Qemu-devel] [PATCH] qdev: Reject duplicate and anti-social device IDs

2010-05-31 Thread Markus Armbruster
We need Device IDs to be unique and not contain '/' so device tree nodes can always be unambigously referenced by tree path. We already have some protection against duplicate IDs, but it got holes: * We don't assign IDs to default devices. * -device and device_add use the ID of a qemu_device_opt