Re: [Qemu-devel] [PATCH] qdev: fix crash when device_add is called with abstract driver

2013-09-17 Thread Andreas Färber
Am 17.09.2013 15:32, schrieb Igor Mammedov: > user is able to crash running QEMU when following monitor > command is called: > > device_add intel-hda-generic > > crash is caused by assertion in object_initialize_with_type() > when type is abstract. > > Checking if type is abstract before instan

Re: [Qemu-devel] [PATCH] qdev: fix crash when device_add is called with abstract driver

2013-09-17 Thread Luiz Capitulino
On Tue, 17 Sep 2013 19:42:08 +0200 Andreas Färber wrote: > > diff --git a/qdev-monitor.c b/qdev-monitor.c > > index 410cdcb..bb2e1b6 100644 > > --- a/qdev-monitor.c > > +++ b/qdev-monitor.c > > @@ -472,6 +472,12 @@ DeviceState *qdev_device_add(QemuOpts *opts) > > return NULL; > > }

Re: [Qemu-devel] [PATCH] qdev: fix crash when device_add is called with abstract driver

2013-09-17 Thread Paolo Bonzini
Il 17/09/2013 15:32, Igor Mammedov ha scritto: > user is able to crash running QEMU when following monitor > command is called: > > device_add intel-hda-generic > > crash is caused by assertion in object_initialize_with_type() > when type is abstract. > > Checking if type is abstract before ins

[Qemu-devel] [PATCH] qdev: fix crash when device_add is called with abstract driver

2013-09-17 Thread Igor Mammedov
user is able to crash running QEMU when following monitor command is called: device_add intel-hda-generic crash is caused by assertion in object_initialize_with_type() when type is abstract. Checking if type is abstract before instance is created in qdev_device_add() allows to prevent crash on