On 04/15/2016 06:06 PM, Paolo Bonzini wrote:
Here's my try rewording the comment (sticking to GTK-Doc conventions
even though I dislike them):
/**
* @qdev_property_add_static:
* @dev: Device to add the property to
* @prop: The qdev property definition
* @err: location to store erro
On 12/04/2016 10:20, Markus Armbruster wrote:
> QOM replaced the static DeviceInfo. The static qdev property arrays
> remain, but they're now stored into their DeviceClass's member props
> dynamically, by the TypeInfo's class_init() method.
>
> The qdev properties so stored get mapped to QOM pr
On 04/12/2016 04:20 PM, Markus Armbruster wrote:
Here's my try rewording the comment (sticking to GTK-Doc conventions
even though I dislike them):
/**
* @qdev_property_add_static:
* @dev: Device to add the property to
* @prop: The qdev property definition
* @err: location to store er
Cao jin writes:
> On 04/08/2016 07:17 PM, Markus Armbruster wrote:
>
>>> - * Static properties access data in a struct. The actual type of the
>>> - * property and the field depends on the property type.
>>> + * Static properties access data in a struct. The actual type of
>>> ObjectProperty
>>
On 04/08/2016 07:17 PM, Markus Armbruster wrote:
- * Static properties access data in a struct. The actual type of the
- * property and the field depends on the property type.
+ * Static properties access data in a struct. The actual type of ObjectProperty
+ * and the struct field depends on
[Wasn't delivered correctly by eggs.gnu.org, resending]
The subsystem tag should be just "qdev:". Suggest "qdev: Clean up
around properties".
Cao jin writes:
> include:
> 1. remove unnecessary declaration of static function
> 2. fix inconsistency between comment and function name, and typo OOM
On 03/24/2016 07:25 PM, Paolo Bonzini wrote:
A question about legacy property: I don`t see legacy property is really
used in the code, so, why still add legacy property to object?
It's used here:
static void qdev_print_props(Monitor *mon, DeviceState *dev, Property *props,
On 24/03/2016 11:14, Cao jin wrote:
> include:
> 1. remove unnecessary declaration of static function
> 2. fix inconsistency between comment and function name, and typo OOM->QOM
> 2. update comment of function
>
> Signed-off-by: Cao jin
> ---
> A question about legacy property: I don`t see lega
include:
1. remove unnecessary declaration of static function
2. fix inconsistency between comment and function name, and typo OOM->QOM
2. update comment of function
Signed-off-by: Cao jin
---
A question about legacy property: I don`t see legacy property is really
used in the code, so, why still