Re: [Qemu-devel] [PATCH] qed: fix use-after-free during l2 cache commit

2011-10-12 Thread Stefan Hajnoczi
On Tue, Oct 11, 2011 at 04:22:11PM +0200, Kevin Wolf wrote: > Am 30.09.2011 17:49, schrieb Amit Shah: > > On (Fri) 30 Sep 2011 [16:23:30], Stefan Hajnoczi wrote: > >> On Fri, Sep 30, 2011 at 12:27 PM, Amit Shah wrote: > >>> On (Fri) 30 Sep 2011 [11:39:11], Stefan Hajnoczi wrote: > QED's metad

Re: [Qemu-devel] [PATCH] qed: fix use-after-free during l2 cache commit

2011-10-11 Thread Kevin Wolf
Am 30.09.2011 17:49, schrieb Amit Shah: > On (Fri) 30 Sep 2011 [16:23:30], Stefan Hajnoczi wrote: >> On Fri, Sep 30, 2011 at 12:27 PM, Amit Shah wrote: >>> On (Fri) 30 Sep 2011 [11:39:11], Stefan Hajnoczi wrote: QED's metadata caching strategy allows two parallel requests to race for met

Re: [Qemu-devel] [PATCH] qed: fix use-after-free during l2 cache commit

2011-10-05 Thread Anthony Liguori
On 09/30/2011 05:39 AM, Stefan Hajnoczi wrote: QED's metadata caching strategy allows two parallel requests to race for metadata lookup. The first one to complete will populate the metadata cache and the second one will drop the data it just read in favor of the cached data. There is a use-afte

Re: [Qemu-devel] [PATCH] qed: fix use-after-free during l2 cache commit

2011-10-03 Thread Anthony Liguori
On 09/30/2011 10:26 AM, Stefan Hajnoczi wrote: On Fri, Sep 30, 2011 at 11:39 AM, Stefan Hajnoczi wrote: QED's metadata caching strategy allows two parallel requests to race for metadata lookup. The first one to complete will populate the metadata cache and the second one will drop the data it

Re: [Qemu-devel] [PATCH] qed: fix use-after-free during l2 cache commit

2011-09-30 Thread Amit Shah
On (Fri) 30 Sep 2011 [16:23:30], Stefan Hajnoczi wrote: > On Fri, Sep 30, 2011 at 12:27 PM, Amit Shah wrote: > > On (Fri) 30 Sep 2011 [11:39:11], Stefan Hajnoczi wrote: > >> QED's metadata caching strategy allows two parallel requests to race for > >> metadata lookup.  The first one to complete wi

Re: [Qemu-devel] [PATCH] qed: fix use-after-free during l2 cache commit

2011-09-30 Thread Stefan Hajnoczi
On Fri, Sep 30, 2011 at 11:39 AM, Stefan Hajnoczi wrote: > QED's metadata caching strategy allows two parallel requests to race for > metadata lookup.  The first one to complete will populate the metadata > cache and the second one will drop the data it just read in favor of the > cached data. > >

Re: [Qemu-devel] [PATCH] qed: fix use-after-free during l2 cache commit

2011-09-30 Thread Stefan Hajnoczi
On Fri, Sep 30, 2011 at 12:27 PM, Amit Shah wrote: > On (Fri) 30 Sep 2011 [11:39:11], Stefan Hajnoczi wrote: >> QED's metadata caching strategy allows two parallel requests to race for >> metadata lookup.  The first one to complete will populate the metadata >> cache and the second one will drop t

Re: [Qemu-devel] [PATCH] qed: fix use-after-free during l2 cache commit

2011-09-30 Thread Amit Shah
On (Fri) 30 Sep 2011 [11:39:11], Stefan Hajnoczi wrote: > QED's metadata caching strategy allows two parallel requests to race for > metadata lookup. The first one to complete will populate the metadata > cache and the second one will drop the data it just read in favor of the > cached data. > >

[Qemu-devel] [PATCH] qed: fix use-after-free during l2 cache commit

2011-09-30 Thread Stefan Hajnoczi
QED's metadata caching strategy allows two parallel requests to race for metadata lookup. The first one to complete will populate the metadata cache and the second one will drop the data it just read in favor of the cached data. There is a use-after-free in qed_read_l2_table_cb() and qed_commit_l