Re: [Qemu-devel] [PATCH] qemu: address todo comment in exec.c

2010-05-06 Thread Aurelien Jarno
On Tue, Apr 06, 2010 at 02:18:19PM +0300, Michael S. Tsirkin wrote: > exec.c has a comment 'XXX: optimize' for lduw_phys/stw_phys, > so let's do it, along the lines of stl_phys. > > The reason to address 16 bit accesses specifically is that virtio relies > on these accesses to be done atomically,

Re: [Qemu-devel] [PATCH] qemu: address todo comment in exec.c

2010-04-11 Thread Michael S. Tsirkin
On Sat, Apr 10, 2010 at 12:33:53AM +0200, Aurelien Jarno wrote: > On Tue, Apr 06, 2010 at 02:18:19PM +0300, Michael S. Tsirkin wrote: > > exec.c has a comment 'XXX: optimize' for lduw_phys/stw_phys, > > so let's do it, along the lines of stl_phys. > > > > The reason to address 16 bit accesses spec

Re: [Qemu-devel] [PATCH] qemu: address todo comment in exec.c

2010-04-09 Thread Aurelien Jarno
On Tue, Apr 06, 2010 at 02:18:19PM +0300, Michael S. Tsirkin wrote: > exec.c has a comment 'XXX: optimize' for lduw_phys/stw_phys, > so let's do it, along the lines of stl_phys. > > The reason to address 16 bit accesses specifically is that virtio relies > on these accesses to be done atomically,

[Qemu-devel] [PATCH] qemu: address todo comment in exec.c

2010-04-06 Thread Michael S. Tsirkin
exec.c has a comment 'XXX: optimize' for lduw_phys/stw_phys, so let's do it, along the lines of stl_phys. The reason to address 16 bit accesses specifically is that virtio relies on these accesses to be done atomically, using memset as we do now breaks this assumption, which is reported to cause q