Re: [Qemu-devel] [PATCH] qemu-char: really fix behavior on can_read = 0

2013-04-08 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] qemu-char: really fix behavior on can_read = 0

2013-04-08 Thread Paolo Bonzini
Il 08/04/2013 16:08, Hans de Goede ha scritto: > >> I misread the glib manual, g_source_remove does not let you re-attach >> the source later. This behavior (called "blocking" the source in glib) >> is present in glib's source code, but private and not available outside >> glib; > > Hmm, have yo

Re: [Qemu-devel] [PATCH] qemu-char: really fix behavior on can_read = 0

2013-04-08 Thread Hans de Goede
Paolo Bonzini writes: I misread the glib manual, g_source_remove does not let you re-attach the source later. This behavior (called "blocking" the source in glib) is present in glib's source code, but private and not available outside glib; Hmm, have you filed a bug upstream asking them to m

Re: [Qemu-devel] [PATCH] qemu-char: really fix behavior on can_read = 0

2013-04-08 Thread Anthony Liguori
Paolo Bonzini writes: > I misread the glib manual, g_source_remove does not let you re-attach > the source later. This behavior (called "blocking" the source in glib) > is present in glib's source code, but private and not available outside > glib; hence, we have to resort to re-creating the sou

[Qemu-devel] [PATCH] qemu-char: really fix behavior on can_read = 0

2013-04-08 Thread Paolo Bonzini
I misread the glib manual, g_source_remove does not let you re-attach the source later. This behavior (called "blocking" the source in glib) is present in glib's source code, but private and not available outside glib; hence, we have to resort to re-creating the source every time. In fact, g_sour