Re: [Qemu-devel] [PATCH] qemu-img: Add --backing-chain option to info command

2012-10-13 Thread Kashyap Chamarthy
On Sun, Oct 14, 2012 at 3:06 AM, Eric Blake wrote: > On 10/13/2012 09:50 AM, Kashyap Chamarthy wrote: > >> >> [PS: I haven't used 'git-send-email' for this trivial patch. Should I >> have used that, instead of attaching it? I was wondering if >> attachments like these are frowned upon. ] > > That

Re: [Qemu-devel] [PATCH] qemu-img: Add --backing-chain option to info command

2012-10-13 Thread Eric Blake
On 10/13/2012 09:50 AM, Kashyap Chamarthy wrote: > > [PS: I haven't used 'git-send-email' for this trivial patch. Should I > have used that, instead of attaching it? I was wondering if > attachments like these are frowned upon. ] That depends on who is applying the patch (it won't be me, since I

Re: [Qemu-devel] [PATCH] qemu-img: Add --backing-chain option to info command

2012-10-13 Thread Kashyap Chamarthy
On Sat, Oct 13, 2012 at 2:01 AM, Eric Blake wrote: > On 10/12/2012 02:19 PM, Kashyap Chamarthy wrote: > >> >> From eb4c4bc92c035c42c23c30c5e7ee73b54f9cf3a8 Mon Sep 17 00:00:00 2001 >> From: Kashyap Chamarthy >> Date: Sat, 13 Oct 2012 01:30:37 +0530 >> Subject: [PATCH] Add documentation for 'qemu-

Re: [Qemu-devel] [PATCH] qemu-img: Add --backing-chain option to info command

2012-10-12 Thread Eric Blake
On 10/12/2012 02:19 PM, Kashyap Chamarthy wrote: > > From eb4c4bc92c035c42c23c30c5e7ee73b54f9cf3a8 Mon Sep 17 00:00:00 2001 > From: Kashyap Chamarthy > Date: Sat, 13 Oct 2012 01:30:37 +0530 > Subject: [PATCH] Add documentation for 'qemu-img info --backing-chain' > > Signed-off-by: Kashyap Chama

Re: [Qemu-devel] [PATCH] qemu-img: Add --backing-chain option to info command

2012-10-12 Thread Kashyap Chamarthy
On Sat, Oct 13, 2012 at 12:46 AM, Kashyap Chamarthy wrote: > On Fri, Oct 12, 2012 at 7:39 PM, Stefan Hajnoczi wrote: >> The qemu-img info --backing-chain option enumerates the backing file >> chain. For example, for base.qcow2 <- snap1.qcow2 <- snap2.qcow2 the >> output becomes: >> >> $ qemu-i

Re: [Qemu-devel] [PATCH] qemu-img: Add --backing-chain option to info command

2012-10-12 Thread Kashyap Chamarthy
On Fri, Oct 12, 2012 at 7:39 PM, Stefan Hajnoczi wrote: > The qemu-img info --backing-chain option enumerates the backing file > chain. For example, for base.qcow2 <- snap1.qcow2 <- snap2.qcow2 the > output becomes: > > $ qemu-img info --backing-chain snap2.qcow2 > image: snap2.qcow2 > file

[Qemu-devel] [PATCH] qemu-img: Add --backing-chain option to info command

2012-10-12 Thread Stefan Hajnoczi
The qemu-img info --backing-chain option enumerates the backing file chain. For example, for base.qcow2 <- snap1.qcow2 <- snap2.qcow2 the output becomes: $ qemu-img info --backing-chain snap2.qcow2 image: snap2.qcow2 file format: qcow2 virtual size: 100M (104857600 bytes) disk size: 196

Re: [Qemu-devel] [PATCH] qemu-img: Add --backing-chain option to info command

2012-10-12 Thread Eric Blake
On 10/12/2012 08:38 AM, Kevin Wolf wrote: >> Hmm. For 'qemu-img info', I can see two behaviors, both useful, when >> presented with a corrupt image. One is to error out right away (because >> qemu would be unable to use the image). But the other is for debugging >> WHY the image is corrupt, at w

Re: [Qemu-devel] [PATCH] qemu-img: Add --backing-chain option to info command

2012-10-12 Thread Kevin Wolf
Am 12.10.2012 16:32, schrieb Eric Blake: > On 10/12/2012 08:27 AM, Kevin Wolf wrote: >> Am 12.10.2012 16:24, schrieb Eric Blake: >>> On 10/12/2012 08:09 AM, Stefan Hajnoczi wrote: The qemu-img info --backing-chain option enumerates the backing file chain. For example, for base.qcow2 <- s

Re: [Qemu-devel] [PATCH] qemu-img: Add --backing-chain option to info command

2012-10-12 Thread Eric Blake
On 10/12/2012 08:27 AM, Kevin Wolf wrote: > Am 12.10.2012 16:24, schrieb Eric Blake: >> On 10/12/2012 08:09 AM, Stefan Hajnoczi wrote: >>> The qemu-img info --backing-chain option enumerates the backing file >>> chain. For example, for base.qcow2 <- snap1.qcow2 <- snap2.qcow2 the >>> output become

Re: [Qemu-devel] [PATCH] qemu-img: Add --backing-chain option to info command

2012-10-12 Thread Kevin Wolf
Am 12.10.2012 16:24, schrieb Eric Blake: > On 10/12/2012 08:09 AM, Stefan Hajnoczi wrote: >> The qemu-img info --backing-chain option enumerates the backing file >> chain. For example, for base.qcow2 <- snap1.qcow2 <- snap2.qcow2 the >> output becomes: >> > >> +do { >> +bs = bdrv_new_

Re: [Qemu-devel] [PATCH] qemu-img: Add --backing-chain option to info command

2012-10-12 Thread Eric Blake
On 10/12/2012 08:09 AM, Stefan Hajnoczi wrote: > The qemu-img info --backing-chain option enumerates the backing file > chain. For example, for base.qcow2 <- snap1.qcow2 <- snap2.qcow2 the > output becomes: > > +do { > +bs = bdrv_new_open(filename, fmt, BDRV_O_FLAGS | BDRV_O_NO_BACKI

Re: [Qemu-devel] [PATCH] qemu-img: Add --backing-chain option to info command

2012-10-12 Thread Eric Blake
On 10/12/2012 08:09 AM, Stefan Hajnoczi wrote: > The qemu-img info --backing-chain option enumerates the backing file > chain. For example, for base.qcow2 <- snap1.qcow2 <- snap2.qcow2 the > output becomes: > > $ qemu-img info --backing-chain snap2.qcow2 > image: snap2.qcow2 > file format: