Re: [Qemu-devel] [PATCH] qemu-img: print error codes when convert fails

2011-08-18 Thread Stefan Hajnoczi
On Wed, Aug 17, 2011 at 08:40:57PM +0200, Kevin Wolf wrote: Am 17.08.2011 18:41, schrieb Stefan Hajnoczi: Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com Thanks, applied to the block branch. (But is it really helpful to include sector numbers in the error message? Especially

[Qemu-devel] [PATCH] qemu-img: print error codes when convert fails

2011-08-17 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- qemu-img.c | 13 - 1 files changed, 8 insertions(+), 5 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index b205e98..d9e6fc8 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -890,7 +890,8 @@ static int img_convert(int

Re: [Qemu-devel] [PATCH] qemu-img: print error codes when convert fails

2011-08-17 Thread Kevin Wolf
Am 17.08.2011 18:41, schrieb Stefan Hajnoczi: Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com Thanks, applied to the block branch. (But is it really helpful to include sector numbers in the error message? Especially since we're not reading/writing single sectors) Kevin