Re: [Qemu-devel] [PATCH] qemu-io: Fix memory leak in 'aio_write -z'

On 05/09/2016 04:03 AM, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > qemu-io-cmds.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Eric Blake Perhaps it would be easier to convert all the mid-function returns into 'goto cleanup', so that we

[Qemu-devel] [PATCH] qemu-io: Fix memory leak in 'aio_write -z'

Signed-off-by: Kevin Wolf --- qemu-io-cmds.c | 1 + 1 file changed, 1 insertion(+) diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c index e34f777..41580b5 100644 --- a/qemu-io-cmds.c +++ b/qemu-io-cmds.c @@ -1699,6 +1699,7 @@ static int aio_write_f(BlockBackend *blk, int argc,

Re: [Qemu-devel] [PATCH] qemu-io: Fix memory leak

On (Wed) Nov 18 2009 [10:42:59], Kevin Wolf wrote: Signed-off-by: Kevin Wolf kw...@redhat.com --- qemu-io.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/qemu-io.c b/qemu-io.c index cac72e9..c84b361 100644 --- a/qemu-io.c +++ b/qemu-io.c @@ -129,7

Re: [Qemu-devel] [PATCH] qemu-io: Fix memory leak

Am 20.11.2009 09:05, schrieb Amit Shah: On (Wed) Nov 18 2009 [10:42:59], Kevin Wolf wrote: Signed-off-by: Kevin Wolf kw...@redhat.com --- qemu-io.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/qemu-io.c b/qemu-io.c index cac72e9..c84b361 100644 ---

[Qemu-devel] [PATCH] qemu-io: Fix memory leak

Signed-off-by: Kevin Wolf kw...@redhat.com --- qemu-io.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/qemu-io.c b/qemu-io.c index cac72e9..c84b361 100644 --- a/qemu-io.c +++ b/qemu-io.c @@ -129,7 +129,8 @@ create_iovec(QEMUIOVector *qiov, char **argv, int

Re: [Qemu-devel] [PATCH] qemu-io: Fix memory leak

Looks good, Reviewed-by: Christoph Hellwig h...@lst.de