Re: [Qemu-devel] [PATCH] qemu-log: Remove qemu_log_try_set_file() and its users

2013-02-23 Thread Blue Swirl
On Mon, Feb 18, 2013 at 11:36 AM, Peter Maydell wrote: > On 16 February 2013 13:52, Blue Swirl wrote: >> On Tue, Feb 12, 2013 at 4:13 PM, Peter Maydell >> wrote: >>> Remove the function qemu_log_try_set_file() and its users (which >>> are all in TCG code generation functions for various targets

Re: [Qemu-devel] [PATCH] qemu-log: Remove qemu_log_try_set_file() and its users

2013-02-18 Thread Peter Maydell
On 16 February 2013 13:52, Blue Swirl wrote: > On Tue, Feb 12, 2013 at 4:13 PM, Peter Maydell > wrote: >> Remove the function qemu_log_try_set_file() and its users (which >> are all in TCG code generation functions for various targets). > Thanks, applied. ...this doesn't seem to be in master?

Re: [Qemu-devel] [PATCH] qemu-log: Remove qemu_log_try_set_file() and its users

2013-02-16 Thread Blue Swirl
Thanks, applied. On Tue, Feb 12, 2013 at 4:13 PM, Peter Maydell wrote: > Remove the function qemu_log_try_set_file() and its users (which > are all in TCG code generation functions for various targets). > This function was added to abstract out code which was originally > written as "if (!logfile

Re: [Qemu-devel] [PATCH] qemu-log: Remove qemu_log_try_set_file() and its users

2013-02-12 Thread Michael Walle
Peter Maydell schrieb: >Remove the function qemu_log_try_set_file() and its users (which >are all in TCG code generation functions for various targets). >This function was added to abstract out code which was originally >written as "if (!logfile) logfile = stderr;" in order that BUG: >case co

Re: [Qemu-devel] [PATCH] qemu-log: Remove qemu_log_try_set_file() and its users

2013-02-12 Thread Andreas Färber
Am 12.02.2013 17:13, schrieb Peter Maydell: > Remove the function qemu_log_try_set_file() and its users (which > are all in TCG code generation functions for various targets). > This function was added to abstract out code which was originally > written as "if (!logfile) logfile = stderr;" in order

[Qemu-devel] [PATCH] qemu-log: Remove qemu_log_try_set_file() and its users

2013-02-12 Thread Peter Maydell
Remove the function qemu_log_try_set_file() and its users (which are all in TCG code generation functions for various targets). This function was added to abstract out code which was originally written as "if (!logfile) logfile = stderr;" in order that BUG: case code which did an unguarded "fprintf