[Xen-devel] Re: [Qemu-devel] [PATCH] qemu and qemu-xen: support empty write barriers in xen_disk

2010-12-14 Thread Ian Jackson
Gerd Hoffmann writes ("[Xen-devel] Re: [Qemu-devel] [PATCH] qemu and qemu-xen: support empty write barriers in xen_disk"): > On 11/24/10 14:08, Stefano Stabellini wrote: > > this patch can be applied to both qemu-xen and qemu and adds support > > for empty write barrier

Re: [Xen-devel] Re: [Qemu-devel] [PATCH] qemu and qemu-xen: support empty write barriers in xen_disk

2010-11-26 Thread Stefano Stabellini
On Fri, 26 Nov 2010, Kevin Wolf wrote: > Am 24.11.2010 19:44, schrieb Christoph Hellwig: > > On Wed, Nov 24, 2010 at 10:18:40AM -0800, Jeremy Fitzhardinge wrote: > >> Linux wants is a useful thing to do and implement (especially since it > >> amounts to standardising the ?BSD extension). I'm not s

Re: [Xen-devel] Re: [Qemu-devel] [PATCH] qemu and qemu-xen: support empty write barriers in xen_disk

2010-11-26 Thread Christoph Hellwig
On Fri, Nov 26, 2010 at 12:03:35PM +0100, Kevin Wolf wrote: > I don't think the synchronous flushes even do what they're supposed to > do. Shouldn't ioreq->postsync do the flush after the request has > completed instead of doing it as soon as it has been submitted? Indeed, that's yet another bug i

Re: [Xen-devel] Re: [Qemu-devel] [PATCH] qemu and qemu-xen: support empty write barriers in xen_disk

2010-11-26 Thread Kevin Wolf
Am 24.11.2010 19:44, schrieb Christoph Hellwig: > On Wed, Nov 24, 2010 at 10:18:40AM -0800, Jeremy Fitzhardinge wrote: >> Linux wants is a useful thing to do and implement (especially since it >> amounts to standardising the ?BSD extension). I'm not sure of their >> precise semantics (esp WRT orde

Re: [Xen-devel] Re: [Qemu-devel] [PATCH] qemu and qemu-xen: support empty write barriers in xen_disk

2010-11-25 Thread Christoph Hellwig
On Thu, Nov 25, 2010 at 11:46:40AM -0800, Jeremy Fitzhardinge wrote: > The latter. There's a question over whether WRITE_BARRIER really > supports empty barriers, since it appears that none of the existing > backends implement it correctly - but on the other hand, the kernel > blkback code does *t

Re: [Xen-devel] Re: [Qemu-devel] [PATCH] qemu and qemu-xen: support empty write barriers in xen_disk

2010-11-25 Thread Jeremy Fitzhardinge
On 11/25/2010 11:30 AM, Ian Jackson wrote: > Christoph Hellwig writes ("Re: [Xen-devel] Re: [Qemu-devel] [PATCH] qemu and > qemu-xen: support empty write barriers in xen_disk"): >> On Wed, Nov 24, 2010 at 10:18:40AM -0800, Jeremy Fitzhardinge wrote: >>> Linux wa

Re: [Xen-devel] Re: [Qemu-devel] [PATCH] qemu and qemu-xen: support empty write barriers in xen_disk

2010-11-25 Thread Ian Jackson
Christoph Hellwig writes ("Re: [Xen-devel] Re: [Qemu-devel] [PATCH] qemu and qemu-xen: support empty write barriers in xen_disk"): > On Wed, Nov 24, 2010 at 10:18:40AM -0800, Jeremy Fitzhardinge wrote: > > Linux wants is a useful thing to do and implement (especially sinc

Re: [Xen-devel] Re: [Qemu-devel] [PATCH] qemu and qemu-xen: support empty write barriers in xen_disk

2010-11-24 Thread Stefano Stabellini
On Wed, 24 Nov 2010, Christoph Hellwig wrote: > On Wed, Nov 24, 2010 at 10:18:40AM -0800, Jeremy Fitzhardinge wrote: > > Linux wants is a useful thing to do and implement (especially since it > > amounts to standardising the ?BSD extension). I'm not sure of their > > precise semantics (esp WRT ord

Re: [Xen-devel] Re: [Qemu-devel] [PATCH] qemu and qemu-xen: support empty write barriers in xen_disk

2010-11-24 Thread Christoph Hellwig
On Wed, Nov 24, 2010 at 10:18:40AM -0800, Jeremy Fitzhardinge wrote: > Linux wants is a useful thing to do and implement (especially since it > amounts to standardising the ?BSD extension). I'm not sure of their > precise semantics (esp WRT ordering), but I think its already OK. The nice bit is t

Re: [Qemu-devel] [PATCH] qemu and qemu-xen: support empty write barriers in xen_disk

2010-11-24 Thread Christoph Hellwig
I had the discussion with Jeremy in Boston before, but let's repeat it here: - is there actually any pre-existing xen backend that does properly implement empty barries. Back then we couldn't find any. - if this is a new concept to Xen please do not define an empty barrier primitive, but

Re: [Xen-devel] Re: [Qemu-devel] [PATCH] qemu and qemu-xen: support empty write barriers in xen_disk

2010-11-24 Thread Jeremy Fitzhardinge
On 11/24/2010 08:58 AM, Christoph Hellwig wrote: > I had the discussion with Jeremy in Boston before, but let's repeat it > here: > > - is there actually any pre-existing xen backend that does properly >implement empty barries. Back then we couldn't find any. > - if this is a new concept to

Re: [Qemu-devel] [PATCH] qemu and qemu-xen: support empty write barriers in xen_disk

2010-11-24 Thread Stefano Stabellini
On Wed, 24 Nov 2010, Kevin Wolf wrote: > > On 11/24/10 14:08, Stefano Stabellini wrote: > >> this patch can be applied to both qemu-xen and qemu and adds support > >> for empty write barriers to xen_disk. > > > > Looks good. > > > > Acked-by: Gerd Hoffmann > > Thanks, applied to the block branc

Re: [Qemu-devel] [PATCH] qemu and qemu-xen: support empty write barriers in xen_disk

2010-11-24 Thread Kevin Wolf
Am 24.11.2010 15:23, schrieb Gerd Hoffmann: > On 11/24/10 14:08, Stefano Stabellini wrote: >> this patch can be applied to both qemu-xen and qemu and adds support >> for empty write barriers to xen_disk. > > Looks good. > > Acked-by: Gerd Hoffmann Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] [PATCH] qemu and qemu-xen: support empty write barriers in xen_disk

2010-11-24 Thread Gerd Hoffmann
On 11/24/10 14:08, Stefano Stabellini wrote: this patch can be applied to both qemu-xen and qemu and adds support for empty write barriers to xen_disk. Looks good. Acked-by: Gerd Hoffmann cheers, Gerd

[Qemu-devel] [PATCH] qemu and qemu-xen: support empty write barriers in xen_disk

2010-11-24 Thread Stefano Stabellini
Hi all, this patch can be applied to both qemu-xen and qemu and adds support for empty write barriers to xen_disk. Signed-off-by: Stefano Stabellini diff --git a/hw/xen_disk.c b/hw/xen_disk.c index 38b5fbf..94af001 100644 --- a/hw/xen_disk.c +++ b/hw/xen_disk.c @@ -182,6 +182,10 @@ static int io