Re: [Qemu-devel] [PATCH] qemu_opt_print: Remove shadowing opt decl

2017-10-06 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > Markus Armbruster writes: > > > "Dr. David Alan Gilbert (git)" writes: > > > >> From: "Dr. David Alan Gilbert" > >> > >> opt was declared as a separate local inside the last loop, > >> shadowing the local at the top of the function. > >> > >> Sig

Re: [Qemu-devel] [PATCH] qemu_opt_print: Remove shadowing opt decl

2017-10-06 Thread Markus Armbruster
Markus Armbruster writes: > "Dr. David Alan Gilbert (git)" writes: > >> From: "Dr. David Alan Gilbert" >> >> opt was declared as a separate local inside the last loop, >> shadowing the local at the top of the function. >> >> Signed-off-by: Dr. David Alan Gilbert > > I can take this through my

Re: [Qemu-devel] [PATCH] qemu_opt_print: Remove shadowing opt decl

2017-10-06 Thread Markus Armbruster
"Dr. David Alan Gilbert (git)" writes: > From: "Dr. David Alan Gilbert" > > opt was declared as a separate local inside the last loop, > shadowing the local at the top of the function. > > Signed-off-by: Dr. David Alan Gilbert I can take this through my tree.

Re: [Qemu-devel] [PATCH] qemu_opt_print: Remove shadowing opt decl

2017-10-05 Thread Eric Blake
On 10/05/2017 02:07 PM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > opt was declared as a separate local inside the last loop, > shadowing the local at the top of the function. > > Signed-off-by: Dr. David Alan Gilbert > --- > util/qemu-option.c | 2 +- > 1 file ch

[Qemu-devel] [PATCH] qemu_opt_print: Remove shadowing opt decl

2017-10-05 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" opt was declared as a separate local inside the last loop, shadowing the local at the top of the function. Signed-off-by: Dr. David Alan Gilbert --- util/qemu-option.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/qemu-option.c b/util/q