Re: [Qemu-devel] [PATCH] qemu_ram_ptr_length: take ram_addr_t as arguments

2011-06-27 Thread Stefano Stabellini
On Mon, 27 Jun 2011, Peter Maydell wrote: > On 27 June 2011 14:34, Stefano Stabellini > wrote: > > On Fri, 24 Jun 2011, Peter Maydell wrote: > >> You probably want to only call qemu_ram_ptr_length() if (todo). > >> (I don't know if anybody ever calls this routine with a zero input > >> length, but

Re: [Qemu-devel] [PATCH] qemu_ram_ptr_length: take ram_addr_t as arguments

2011-06-27 Thread Peter Maydell
On 27 June 2011 14:34, Stefano Stabellini wrote: > On Fri, 24 Jun 2011, Peter Maydell wrote: >> You probably want to only call qemu_ram_ptr_length() if (todo). >> (I don't know if anybody ever calls this routine with a zero input >> length, but that would handle that case too.) > > I would rather

Re: [Qemu-devel] [PATCH] qemu_ram_ptr_length: take ram_addr_t as arguments

2011-06-27 Thread Stefano Stabellini
On Fri, 24 Jun 2011, Peter Maydell wrote: > On 24 June 2011 12:08, wrote: > > From: Stefano Stabellini > > > > qemu_ram_ptr_length should take ram_addr_t as argument rather than > > target_phys_addr_t because is doing comparisons with RAMBlock addresses. > > > > cpu_physical_memory_map should cr

Re: [Qemu-devel] [PATCH] qemu_ram_ptr_length: take ram_addr_t as arguments

2011-06-24 Thread Peter Maydell
On 24 June 2011 12:08, wrote: > From: Stefano Stabellini > > qemu_ram_ptr_length should take ram_addr_t as argument rather than > target_phys_addr_t because is doing comparisons with RAMBlock addresses. > > cpu_physical_memory_map should create a ram_addr_t address to pass to > qemu_ram_ptr_leng

[Qemu-devel] [PATCH] qemu_ram_ptr_length: take ram_addr_t as arguments

2011-06-24 Thread stefano.stabellini
From: Stefano Stabellini qemu_ram_ptr_length should take ram_addr_t as argument rather than target_phys_addr_t because is doing comparisons with RAMBlock addresses. cpu_physical_memory_map should create a ram_addr_t address to pass to qemu_ram_ptr_length from PhysPageDesc phys_offset. Remove co