Hello,
I posted a PATCH v2 yesterday that does this. It returns the result per
filesystem, with the name, mountpoint and filesystem type.
Eric requested output similar to fsinfo (that's why name and type is
included), but I'm not really convinced it is meaningful. Especially
'name' is someth
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 01/04/2015 14:33, Eric Blake wrote:
> It's only a minor incompatibility, but a client that hard-codes
> itself to parsing "returns":0 (that is, expecting a json-number)
> will fail when talking to an older qemu that provided a json-object
> inst
On 04/01/2015 01:54 AM, Paolo Bonzini wrote:
>
>
> On 31/03/2015 19:03, Eric Blake wrote:
Apart from this, looks good.
>> Changing a "return":{} to "return":0 is not backwards-compatible.
>
> Why not?
It's only a minor incompatibility, but a client that hard-codes itself
to parsing "r
On 31/03/2015 19:03, Eric Blake wrote:
>>>
>>> Apart from this, looks good.
> Changing a "return":{} to "return":0 is not backwards-compatible.
Why not?
Paolo
>> I'm CCing the qemu-ga maintainer.
> I failed to do that in my beefier reply, so I'm responding here
> just to say that this needs a
On 03/31/2015 10:52 AM, Paolo Bonzini wrote:
>> -# Returns: Nothing.
>> +# Returns: Number of bytes trimmed by this call.
>
> It's better to add "(since 2.4)" here.
>
> Apart from this, looks good.
Changing a "return":{} to "return":0 is not backwards-compatible.
>
> I'm CCing the qemu-ga mai
On 03/31/2015 09:14 AM, Justin Ossevoort wrote:
> The FITRIM ioctl updates the fstrim_range structure it receives. This
> way the caller can determine how many bytes were trimmed. The
> guest-fstrim logic reuses the same fstrim_range for each filesystem,
> effectively limiting each filesystem to tr
On 31/03/2015 17:14, Justin Ossevoort wrote:
> The FITRIM ioctl updates the fstrim_range structure it receives. This
> way the caller can determine how many bytes were trimmed. The
> guest-fstrim logic reuses the same fstrim_range for each filesystem,
> effectively limiting each filesystem to tri
The FITRIM ioctl updates the fstrim_range structure it receives. This
way the caller can determine how many bytes were trimmed. The
guest-fstrim logic reuses the same fstrim_range for each filesystem,
effectively limiting each filesystem to trim at most as much as the
previous was able to trim.
If
