Re: [Qemu-devel] [PATCH] qga-win: Handle fstrim for OSes lower than Win8

2018-07-23 Thread Michael Roth
Quoting Sameeh Jubran (2018-07-17 00:46:27) > I'v successfully compiled the previous patch on Fedora 27, but it seems to be > failing on RHEL, You can apply this patch instead which avoids using the > versionhelpers header: Thanks, applied to qga tree: https://github.com/mdroth/qemu/commits/qga

Re: [Qemu-devel] [PATCH] qga-win: Handle fstrim for OSes lower than Win8

2018-07-17 Thread Michael Roth
Quoting Daniel P. Berrangé (2018-07-17 04:34:18) > On Mon, Jul 16, 2018 at 03:10:38PM -0500, Michael Roth wrote: > > Quoting Sameeh Jubran (2018-06-24 07:45:40) > > > From: Sameeh Jubran > > > > > > The defrag.exe tool which is used for executing the fstrim command > > > on Windows doesn't suppor

Re: [Qemu-devel] [PATCH] qga-win: Handle fstrim for OSes lower than Win8

2018-07-17 Thread Daniel P . Berrangé
On Mon, Jul 16, 2018 at 03:10:38PM -0500, Michael Roth wrote: > Quoting Sameeh Jubran (2018-06-24 07:45:40) > > From: Sameeh Jubran > > > > The defrag.exe tool which is used for executing the fstrim command > > on Windows doesn't support retrim for OSes lower than Win8. This > > commit handles th

Re: [Qemu-devel] [PATCH] qga-win: Handle fstrim for OSes lower than Win8

2018-07-16 Thread Sameeh Jubran
I'v successfully compiled the previous patch on Fedora 27, but it seems to be failing on RHEL, You can apply this patch instead which avoids using the versionhelpers header: --- qga/commands-win32.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/qga/commands-win32.c b/qga/command

Re: [Qemu-devel] [PATCH] qga-win: Handle fstrim for OSes lower than Win8

2018-07-16 Thread Michael Roth
Quoting Sameeh Jubran (2018-06-24 07:45:40) > From: Sameeh Jubran > > The defrag.exe tool which is used for executing the fstrim command > on Windows doesn't support retrim for OSes lower than Win8. This > commit handles this case and returns a suitable error. > > Output of fstrim before this co

Re: [Qemu-devel] [PATCH] qga-win: Handle fstrim for OSes lower than Win8

2018-07-16 Thread Sameeh Jubran
ping. On Sun, Jun 24, 2018 at 3:45 PM, Sameeh Jubran wrote: > From: Sameeh Jubran > > The defrag.exe tool which is used for executing the fstrim command > on Windows doesn't support retrim for OSes lower than Win8. This > commit handles this case and returns a suitable error. > > Output of fstr

[Qemu-devel] [PATCH] qga-win: Handle fstrim for OSes lower than Win8

2018-06-24 Thread Sameeh Jubran
From: Sameeh Jubran The defrag.exe tool which is used for executing the fstrim command on Windows doesn't support retrim for OSes lower than Win8. This commit handles this case and returns a suitable error. Output of fstrim before this commit: {"execute":"guest-fstrim"} {"return": {"paths": [{"p