Re: [Qemu-devel] [PATCH] qmp: Give saner messages related to qmp_capabilities misuse

2015-04-21 Thread Luiz Capitulino
On Wed, 15 Apr 2015 09:19:23 -0600 Eric Blake wrote: > Pretending that QMP doesn't understand a command merely because > we are not in the right mode doesn't help first-time users figure > out what to do to correct things. Although the documentation for > QMP calls out capabilities negotiation,

Re: [Qemu-devel] [PATCH] qmp: Give saner messages related to qmp_capabilities misuse

2015-04-15 Thread John Snow
On 04/15/2015 02:31 PM, Eric Blake wrote: On 04/15/2015 12:13 PM, John Snow wrote: On 04/15/2015 11:19 AM, Eric Blake wrote: Pretending that QMP doesn't understand a command merely because we are not in the right mode doesn't help first-time users figure out what to do to correct things. A

Re: [Qemu-devel] [PATCH] qmp: Give saner messages related to qmp_capabilities misuse

2015-04-15 Thread Eric Blake
On 04/15/2015 12:13 PM, John Snow wrote: > > > On 04/15/2015 11:19 AM, Eric Blake wrote: >> Pretending that QMP doesn't understand a command merely because >> we are not in the right mode doesn't help first-time users figure >> out what to do to correct things. Although the documentation for >>

Re: [Qemu-devel] [PATCH] qmp: Give saner messages related to qmp_capabilities misuse

2015-04-15 Thread John Snow
On 04/15/2015 11:19 AM, Eric Blake wrote: Pretending that QMP doesn't understand a command merely because we are not in the right mode doesn't help first-time users figure out what to do to correct things. Although the documentation for QMP calls out capabilities negotiation, we should also ma

Re: [Qemu-devel] [PATCH] qmp: Give saner messages related to qmp_capabilities misuse

2015-04-15 Thread Paulo Ricardo Paz Vital
Reviewed-by: Paulo Vital On Wed, 2015-04-15 at 09:19 -0600, Eric Blake wrote: > Pretending that QMP doesn't understand a command merely because > we are not in the right mode doesn't help first-time users figure > out what to do to correct things. Although the documentation for > QMP calls out c

Re: [Qemu-devel] [PATCH] qmp: Give saner messages related to qmp_capabilities misuse

2015-04-15 Thread Kashyap Chamarthy
On Wed, Apr 15, 2015 at 09:19:23AM -0600, Eric Blake wrote: > Pretending that QMP doesn't understand a command merely because > we are not in the right mode doesn't help first-time users figure > out what to do to correct things. Although the documentation for > QMP calls out capabilities negotiat

[Qemu-devel] [PATCH] qmp: Give saner messages related to qmp_capabilities misuse

2015-04-15 Thread Eric Blake
Pretending that QMP doesn't understand a command merely because we are not in the right mode doesn't help first-time users figure out what to do to correct things. Although the documentation for QMP calls out capabilities negotiation, we should also make it clear in our error messages what we were