Re: [Qemu-devel] [PATCH] qom: cpu: destroy work_mutex in cpu_common_finalize

2019-03-10 Thread 李强
Hi Paolo, What's the status of this patch? I don't see it in upstream. Thanks, Li Qiang At 2019-01-08 07:41:09, "Paolo Bonzini" wrote: >On 02/01/19 08:41, Li Qiang wrote: >> Commit 376692b9dc6(cpus: protect work list with work_mutex) >> initialize a work_mutex in cpu_common_initfn, however fo

Re: [Qemu-devel] [PATCH] qom: cpu: destroy work_mutex in cpu_common_finalize

2019-01-07 Thread Paolo Bonzini
On 02/01/19 08:41, Li Qiang wrote: > Commit 376692b9dc6(cpus: protect work list with work_mutex) > initialize a work_mutex in cpu_common_initfn, however forget > to destroy it. This will cause resource leak when hotunplug cpu > or hotplug cpu fails. > > Signed-off-by: Li Qiang > --- > qom/cpu.c

Re: [Qemu-devel] [PATCH] qom: cpu: destroy work_mutex in cpu_common_finalize

2019-01-02 Thread Philippe Mathieu-Daudé
On 1/2/19 8:41 AM, Li Qiang wrote: > Commit 376692b9dc6(cpus: protect work list with work_mutex) > initialize a work_mutex in cpu_common_initfn, however forget > to destroy it. This will cause resource leak when hotunplug cpu > or hotplug cpu fails. > Long standing leak ;) Maybe add: Fixes: 376

[Qemu-devel] [PATCH] qom: cpu: destroy work_mutex in cpu_common_finalize

2019-01-01 Thread Li Qiang
Commit 376692b9dc6(cpus: protect work list with work_mutex) initialize a work_mutex in cpu_common_initfn, however forget to destroy it. This will cause resource leak when hotunplug cpu or hotplug cpu fails. Signed-off-by: Li Qiang --- qom/cpu.c | 3 +++ 1 file changed, 3 insertions(+) diff --gi