Re: [Qemu-devel] [PATCH] qtest: Unlink pid file before reading from QMP

2014-02-17 Thread Stefan Hajnoczi
On Fri, Feb 14, 2014 at 4:38 PM, Andreas Färber wrote: > Am 14.02.2014 15:43, schrieb Stefan Hajnoczi: >> On Sun, Feb 09, 2014 at 12:21:41PM +0100, Andreas Färber wrote: >>> Despite 1ad3c6abc0d67e00b84abaa5527bc64b70ca2205, supplying invalid >>> arguments to the QEMU process still leaked a /tmp/qt

Re: [Qemu-devel] [PATCH] qtest: Unlink pid file before reading from QMP

2014-02-14 Thread Andreas Färber
Am 14.02.2014 15:43, schrieb Stefan Hajnoczi: > On Sun, Feb 09, 2014 at 12:21:41PM +0100, Andreas Färber wrote: >> Despite 1ad3c6abc0d67e00b84abaa5527bc64b70ca2205, supplying invalid >> arguments to the QEMU process still leaked a /tmp/qtest-*.pid file. >> >> Fix this by reordering the reading and

Re: [Qemu-devel] [PATCH] qtest: Unlink pid file before reading from QMP

2014-02-14 Thread Stefan Hajnoczi
On Sun, Feb 09, 2014 at 12:21:41PM +0100, Andreas Färber wrote: > Despite 1ad3c6abc0d67e00b84abaa5527bc64b70ca2205, supplying invalid > arguments to the QEMU process still leaked a /tmp/qtest-*.pid file. > > Fix this by reordering the reading and unlinking to before reading from > QMP socket, whic

[Qemu-devel] [PATCH] qtest: Unlink pid file before reading from QMP

2014-02-09 Thread Andreas Färber
Despite 1ad3c6abc0d67e00b84abaa5527bc64b70ca2205, supplying invalid arguments to the QEMU process still leaked a /tmp/qtest-*.pid file. Fix this by reordering the reading and unlinking to before reading from QMP socket, which relies on a running process. Cc: Stefan Hajnoczi Signed-off-by: Andrea