Re: [Qemu-devel] [PATCH] quorum: don't share qiov

2015-02-08 Thread Wen Congyang
On 02/03/2015 07:01 PM, Paolo Bonzini wrote: On 03/02/2015 10:22, Kevin Wolf wrote: Paolo, I think it's rather surprising that iov_send_recv() modifies its iov. The modification is undone at the end, so you seem to have considered that a caller might be reusing it after and you can't use

Re: [Qemu-devel] [PATCH] quorum: don't share qiov

2015-02-03 Thread Paolo Bonzini
On 03/02/2015 10:22, Kevin Wolf wrote: Paolo, I think it's rather surprising that iov_send_recv() modifies its iov. The modification is undone at the end, so you seem to have considered that a caller might be reusing it after and you can't use it up, but we still get problems with concurrent

Re: [Qemu-devel] [PATCH] quorum: don't share qiov

2015-02-03 Thread Kevin Wolf
Am 02.02.2015 um 02:19 hat Wen Congyang geschrieben: On 01/30/2015 09:39 PM, Kevin Wolf wrote: Am 30.01.2015 um 09:07 hat Wen Congyang geschrieben: If the child touches qiov-iov, it will cause unexpected results. Signed-off-by: Wen Congyang we...@cn.fujitsu.com Any specific child

Re: [Qemu-devel] [PATCH] quorum: don't share qiov

2015-02-01 Thread Wen Congyang
On 01/30/2015 09:39 PM, Kevin Wolf wrote: Am 30.01.2015 um 09:07 hat Wen Congyang geschrieben: If the child touches qiov-iov, it will cause unexpected results. Signed-off-by: Wen Congyang we...@cn.fujitsu.com Any specific child you're thinking of? I think children are not supposed to

[Qemu-devel] [PATCH] quorum: don't share qiov

2015-01-30 Thread Wen Congyang
If the child touches qiov-iov, it will cause unexpected results. Signed-off-by: Wen Congyang we...@cn.fujitsu.com --- block/quorum.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/block/quorum.c b/block/quorum.c index cdc026c..ef0c1e9 100644 --- a/block/quorum.c

Re: [Qemu-devel] [PATCH] quorum: don't share qiov

2015-01-30 Thread Kevin Wolf
Am 30.01.2015 um 09:07 hat Wen Congyang geschrieben: If the child touches qiov-iov, it will cause unexpected results. Signed-off-by: Wen Congyang we...@cn.fujitsu.com Any specific child you're thinking of? I think children are not supposed to modify their qiov (which would also fail for