Re: [Qemu-devel] [PATCH] qxl: properly handle upright and non-shared surfaces

2012-02-28 Thread Alon Levy
On Tue, Feb 28, 2012 at 09:29:38AM +0100, Gerd Hoffmann wrote: > >> -dprint(qxl, 1, "%s: stride %d, [%d, %d, %d, %d]\n", __func__, > >> +dprint(qxl, 2, "%s: stride %d, [%d, %d, %d, %d]\n", __func__, > > > > You know 2 is used right now for high frequency stuff, like > > interface_get_comma

Re: [Qemu-devel] [PATCH] qxl: properly handle upright and non-shared surfaces

2012-02-28 Thread Gerd Hoffmann
>> -dprint(qxl, 1, "%s: stride %d, [%d, %d, %d, %d]\n", __func__, >> +dprint(qxl, 2, "%s: stride %d, [%d, %d, %d, %d]\n", __func__, > > You know 2 is used right now for high frequency stuff, like > interface_get_command? I think this should be lower. Anyway, not a big > deal. /me used '1'

Re: [Qemu-devel] [PATCH] qxl: properly handle upright and non-shared surfaces

2012-02-27 Thread Alon Levy
On Mon, Feb 27, 2012 at 11:10:10AM +0100, Gerd Hoffmann wrote: > Although qxl creates a shared displaysurface when the qxl surface is > upright and doesn't need to be flipped there is no guarantee that the > surface doesn't become unshared for some reason. Rename qxl_flip to > qxl_blit and fix it

[Qemu-devel] [PATCH] qxl: properly handle upright and non-shared surfaces

2012-02-27 Thread Gerd Hoffmann
Although qxl creates a shared displaysurface when the qxl surface is upright and doesn't need to be flipped there is no guarantee that the surface doesn't become unshared for some reason. Rename qxl_flip to qxl_blit and fix it to handle both flip and non-flip cases. Signed-off-by: Gerd Hoffmann