Re: [Qemu-devel] [PATCH] savevm: qemu_savevm_state(): Drop stop VM logic

2011-10-14 Thread Juan Quintela
Luiz Capitulino wrote: > qemu_savevm_state() has some logic to stop the VM and to (or not to) > resume it. But this seems to be a big noop, as qemu_savevm_state() > is only called by do_savevm() when the VM is already stopped. > > So, let's drop qemu_savevm_state()'s stop VM logic. > > Signed-off-

Re: [Qemu-devel] [PATCH] savevm: qemu_savevm_state(): Drop stop VM logic

2011-10-14 Thread Kevin Wolf
Am 13.10.2011 22:27, schrieb Luiz Capitulino: > qemu_savevm_state() has some logic to stop the VM and to (or not to) > resume it. But this seems to be a big noop, as qemu_savevm_state() > is only called by do_savevm() when the VM is already stopped. > > So, let's drop qemu_savevm_state()'s stop VM

Re: [Qemu-devel] [PATCH] savevm: qemu_savevm_state(): Drop stop VM logic

2011-10-13 Thread Michael Roth
Heh, Anthony and I were puzzling over this just before your patch hit the list. Looks good :) Reviewed-by: Michael Roth On Thu, 13 Oct 2011 17:27:53 -0300, Luiz Capitulino wrote: > qemu_savevm_state() has some logic to stop the VM and to (or not to) > resume it. But this seems to be a big noo

[Qemu-devel] [PATCH] savevm: qemu_savevm_state(): Drop stop VM logic

2011-10-13 Thread Luiz Capitulino
qemu_savevm_state() has some logic to stop the VM and to (or not to) resume it. But this seems to be a big noop, as qemu_savevm_state() is only called by do_savevm() when the VM is already stopped. So, let's drop qemu_savevm_state()'s stop VM logic. Signed-off-by: Luiz Capitulino --- savevm.c |