On 10/22/2014 10:13 AM, Michael S. Tsirkin wrote:
> > To me it means that I have time to review patches, but not to do my own
> > work on it.
>
> Intersting.
> review is "other than throw the odd patch in" so it's hardly
> the literal meaning of this text.
Well, review is just the prerequisite/ne
On Wed, Oct 22, 2014 at 10:07:52AM +0200, Paolo Bonzini wrote:
>
>
> On 10/22/2014 10:08 AM, Michael S. Tsirkin wrote:
> >> >
> >> > To me "odd fixes" means I may help shepherding your patches into the
> >> > tree, but I would rather revert a buggy patch than fix it.
> > OK but this is not what
On 10/22/2014 10:08 AM, Michael S. Tsirkin wrote:
>> >
>> > To me "odd fixes" means I may help shepherding your patches into the
>> > tree, but I would rather revert a buggy patch than fix it.
> OK but this is not what MAINTAINERS says:
>
>
>Odd Fixes: It has a maintainer but the
Paolo Bonzini writes:
> On 10/22/2014 09:47 AM, Markus Armbruster wrote:
>> Like this:
>>
>> $ scripts/get_maintainer.pl -f --no-git-fallback hw/ide/core.c
>> Kevin Wolf (odd fixer:IDE)
>> Stefan Hajnoczi (odd fixer:IDE)
>>
>> What's wrong with that?
>
> Michael's patch fixes the
On Wed, Oct 22, 2014 at 09:45:13AM +0200, Paolo Bonzini wrote:
> On 10/22/2014 09:22 AM, Michael S. Tsirkin wrote:
> > Actually, it does not ignore that.
> > What it does it list status as "odd fixer".
> >
> > So this boils down to the fact that we use
> > "odd fixer" incorrectly.
> >
> > I will
On 10/22/2014 09:47 AM, Markus Armbruster wrote:
> Like this:
>
> $ scripts/get_maintainer.pl -f --no-git-fallback hw/ide/core.c
> Kevin Wolf (odd fixer:IDE)
> Stefan Hajnoczi (odd fixer:IDE)
>
> What's wrong with that?
Michael's patch fixes the case where you do _not_ have --no
"Michael S. Tsirkin" writes:
> On Tue, Oct 21, 2014 at 02:35:09PM +0300, Michael S. Tsirkin wrote:
>> We have a bunch of modules in "Odd fixes"
>> status, scripts/get_maintainer.pl ignores that.
>>
>> Reported-by: Gerd Hoffmann
>> Cc: Paolo Bonzini
>> Cc: Peter Maydell
>> Cc: Markus Armbruste
On 10/22/2014 09:22 AM, Michael S. Tsirkin wrote:
> Actually, it does not ignore that.
> What it does it list status as "odd fixer".
>
> So this boils down to the fact that we use
> "odd fixer" incorrectly.
>
> I will apply this for now but maybe we should
> change MAINTAINERS switching all "Odd
On Tue, Oct 21, 2014 at 02:35:09PM +0300, Michael S. Tsirkin wrote:
> We have a bunch of modules in "Odd fixes"
> status, scripts/get_maintainer.pl ignores that.
>
> Reported-by: Gerd Hoffmann
> Cc: Paolo Bonzini
> Cc: Peter Maydell
> Cc: Markus Armbruster
> Signed-off-by: Michael S. Tsirkin
On 10/21/14 07:35, Michael S. Tsirkin wrote:
We have a bunch of modules in "Odd fixes"
status, scripts/get_maintainer.pl ignores that.
Reported-by: Gerd Hoffmann
Cc: Paolo Bonzini
Cc: Peter Maydell
Cc: Markus Armbruster
Signed-off-by: Michael S. Tsirkin
---
scripts/get_maintainer.pl | 2 +
We have a bunch of modules in "Odd fixes"
status, scripts/get_maintainer.pl ignores that.
Reported-by: Gerd Hoffmann
Cc: Paolo Bonzini
Cc: Peter Maydell
Cc: Markus Armbruster
Signed-off-by: Michael S. Tsirkin
---
scripts/get_maintainer.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
11 matches
Mail list logo