[Qemu-devel] [PATCH] scripts: provide a script for checking glib symbol usage

There are frequently patches submitted for merge which use symbols only defined by newer glib versions that the max version currently permitted by QEMU (ie glib==2.22). The glib 2.32 release introduced GLIB_VERSION_MIN_REQUIRED and GLIB_VERSION_MAX_ALLOWED macros to allow apps to declare what they

Re: [Qemu-devel] [PATCH] scripts: provide a script for checking glib symbol usage

On 18/12/2015 12:36, Daniel P. Berrange wrote: > diff --git a/scripts/Makefile b/scripts/Makefile > new file mode 100644 > index 000..162e7e9 > --- /dev/null > +++ b/scripts/Makefile > @@ -0,0 +1,24 @@ > +# > +# This makefile runs various style checks across the entire > +# source tree. > +#

Re: [Qemu-devel] [PATCH] scripts: provide a script for checking glib symbol usage

On Fri, Dec 18, 2015 at 01:36:00PM +0100, Paolo Bonzini wrote: > > > On 18/12/2015 12:36, Daniel P. Berrange wrote: > > diff --git a/scripts/Makefile b/scripts/Makefile > > new file mode 100644 > > index 000..162e7e9 > > --- /dev/null > > +++ b/scripts/Makefile > > @@ -0,0 +1,24 @@ > > +# >

Re: [Qemu-devel] [PATCH] scripts: provide a script for checking glib symbol usage

On 18/12/2015 14:05, Daniel P. Berrange wrote: > > > + > > > +cs-glib-syms: > > > + @perl scripts/glib-syms.pl $(GLIB_SYMS_LIST) $(C_CODE_FILES) > > > > > > Does this need to be included, or could it be a separate Makefile > > invoked with e.g. make -f scripts/Makefile.style? > > Any

Re: [Qemu-devel] [PATCH] scripts: provide a script for checking glib symbol usage

On Fri, Dec 18, 2015 at 01:35:13PM +, Dr. David Alan Gilbert wrote: > * Paolo Bonzini (pbonz...@redhat.com) wrote: > > > > > > On 18/12/2015 14:05, Daniel P. Berrange wrote: > > > > > + > > > > > +cs-glib-syms: > > > > > + @perl scripts/glib-syms.pl $(GLIB_SYMS_LIST) $(C_CODE_FILES) > >

Re: [Qemu-devel] [PATCH] scripts: provide a script for checking glib symbol usage

On 18 December 2015 at 13:41, Paolo Bonzini wrote: > > > On 18/12/2015 14:35, Dr. David Alan Gilbert wrote: >> > That would not be recursive make, but rather a completely separate >> > Makefile to be manually invoked with -f. >> >> Hmm but wouldn't this Makefile also be a

Re: [Qemu-devel] [PATCH] scripts: provide a script for checking glib symbol usage

On 18/12/2015 14:35, Dr. David Alan Gilbert wrote: > > That would not be recursive make, but rather a completely separate > > Makefile to be manually invoked with -f. > > Hmm but wouldn't this Makefile also be a good place for small-fast > style check scripts that could be included in make

Re: [Qemu-devel] [PATCH] scripts: provide a script for checking glib symbol usage

* Paolo Bonzini (pbonz...@redhat.com) wrote: > > > On 18/12/2015 14:05, Daniel P. Berrange wrote: > > > > + > > > > +cs-glib-syms: > > > > + @perl scripts/glib-syms.pl $(GLIB_SYMS_LIST) $(C_CODE_FILES) > > > > > > > > > Does this need to be included, or could it be a separate Makefile >

Re: [Qemu-devel] [PATCH] scripts: provide a script for checking glib symbol usage

On 18 December 2015 at 13:42, Dr. David Alan Gilbert wrote: > "make check" takes under 2m on my laptop, so I take that to be reasonably > fast, i.e. I'd be happy to add other small (few second) tests to it. Is that a 'make check' for a complete all-targets configure? Those

Re: [Qemu-devel] [PATCH] scripts: provide a script for checking glib symbol usage

* Daniel P. Berrange (berra...@redhat.com) wrote: > On Fri, Dec 18, 2015 at 01:35:13PM +, Dr. David Alan Gilbert wrote: > > * Paolo Bonzini (pbonz...@redhat.com) wrote: > > > > > > > > > On 18/12/2015 14:05, Daniel P. Berrange wrote: > > > > > > + > > > > > > +cs-glib-syms: > > > > > > +

Re: [Qemu-devel] [PATCH] scripts: provide a script for checking glib symbol usage

* Peter Maydell (peter.mayd...@linaro.org) wrote: > On 18 December 2015 at 13:42, Dr. David Alan Gilbert > wrote: > > "make check" takes under 2m on my laptop, so I take that to be reasonably > > fast, i.e. I'd be happy to add other small (few second) tests to it. > > Is

Re: [Qemu-devel] [PATCH] scripts: provide a script for checking glib symbol usage

On Fri, Dec 18, 2015 at 01:43:19PM +, Peter Maydell wrote: > On 18 December 2015 at 13:41, Paolo Bonzini wrote: > > > > > > On 18/12/2015 14:35, Dr. David Alan Gilbert wrote: > >> > That would not be recursive make, but rather a completely separate > >> > Makefile to be