Re: [Qemu-devel] [PATCH] scsi: esp: fix migration

2016-07-08 Thread Paolo Bonzini
> > > -VMSTATE_BUFFER(cmdbuf, ESPState), > > > +VMSTATE_PARTIAL_BUFFER(cmdbuf, ESPState, 16), > > > +VMSTATE_BUFFER_START_MIDDLE_V(cmdbuf, ESPState, 16, 4), > > > > Amit, would it help the checker if we do something like: > > > > -VMSTATE_BUFFER(cmdbuf, ESPState),

Re: [Qemu-devel] [PATCH] scsi: esp: fix migration

2016-07-08 Thread Amit Shah
On (Mon) 27 Jun 2016 [09:54:24], Paolo Bonzini wrote: > > > On 27/06/2016 09:20, Amit Shah wrote: > > On (Mon) 20 Jun 2016 [16:33:26], Paolo Bonzini wrote: > >> Commit 926cde5 ("scsi: esp: make cmdbuf big enough for maximum CDB size", > >> 2016-06-16) changed the size of a migrated field. Split

Re: [Qemu-devel] [PATCH] scsi: esp: fix migration

2016-07-08 Thread Amit Shah
On (Wed) 29 Jun 2016 [14:00:17], Juan Quintela wrote: > Paolo Bonzini wrote: > > On 27/06/2016 09:20, Amit Shah wrote: > >> On (Mon) 20 Jun 2016 [16:33:26], Paolo Bonzini wrote: > >>> Commit 926cde5 ("scsi: esp: make cmdbuf big enough for maximum CDB size", > >>> 2016-06-16)

Re: [Qemu-devel] [PATCH] scsi: esp: fix migration

2016-06-29 Thread Juan Quintela
Paolo Bonzini wrote: > On 27/06/2016 09:20, Amit Shah wrote: >> On (Mon) 20 Jun 2016 [16:33:26], Paolo Bonzini wrote: >>> Commit 926cde5 ("scsi: esp: make cmdbuf big enough for maximum CDB size", >>> 2016-06-16) changed the size of a migrated field. Split it in two >>>

Re: [Qemu-devel] [PATCH] scsi: esp: fix migration

2016-06-27 Thread Paolo Bonzini
On 27/06/2016 09:20, Amit Shah wrote: > On (Mon) 20 Jun 2016 [16:33:26], Paolo Bonzini wrote: >> Commit 926cde5 ("scsi: esp: make cmdbuf big enough for maximum CDB size", >> 2016-06-16) changed the size of a migrated field. Split it in two >> parts, and only migrate the second part in a new

Re: [Qemu-devel] [PATCH] scsi: esp: fix migration

2016-06-27 Thread Amit Shah
On (Mon) 20 Jun 2016 [16:33:26], Paolo Bonzini wrote: > Commit 926cde5 ("scsi: esp: make cmdbuf big enough for maximum CDB size", > 2016-06-16) changed the size of a migrated field. Split it in two > parts, and only migrate the second part in a new vmstate version. With this patch, the static

[Qemu-devel] [PATCH] scsi: esp: fix migration

2016-06-20 Thread Paolo Bonzini
Commit 926cde5 ("scsi: esp: make cmdbuf big enough for maximum CDB size", 2016-06-16) changed the size of a migrated field. Split it in two parts, and only migrate the second part in a new vmstate version. Signed-off-by: Paolo Bonzini --- hw/scsi/esp.c | 5