Re: [Qemu-devel] [PATCH] sh4-linux-user: fix multi-threading regression.

2012-03-30 Thread cedric.vinc...@st.com
On Mon, Mar 26, 2012 at 03:07:18PM +0200, Cedric VINCENT wrote: > This reverts commit fd4bab10 "target-sh4: optimize exceptions": the > function cpu_restore_state() isn't expected to be called in user-mode, > as a consequence it isn't protected from race conditions. For > information, syscalls are

Re: [Qemu-devel] [PATCH] sh4-linux-user: fix multi-threading regression.

2012-03-27 Thread cedric.vincent
On Mon, Mar 26, 2012 at 07:23:58PM +0200, Peter Maydell wrote: > 2012/3/26 Cédric VINCENT : > > This reverts commit fd4bab10 "target-sh4: optimize exceptions": > > [cc'ing Aurelien as the author of that commit] > > > the function cpu_restore_state() isn't expected to be called in user-mode, > >

Re: [Qemu-devel] [PATCH] sh4-linux-user: fix multi-threading regression.

2012-03-26 Thread Peter Maydell
2012/3/26 Cédric VINCENT : > This reverts commit fd4bab10 "target-sh4: optimize exceptions": [cc'ing Aurelien as the author of that commit] > the function cpu_restore_state() isn't expected to be called in user-mode, Is this really true? host_signal_handler() calls cpu_signal_handler() calls han

[Qemu-devel] [PATCH] sh4-linux-user: fix multi-threading regression.

2012-03-26 Thread Cédric VINCENT
This reverts commit fd4bab10 "target-sh4: optimize exceptions": the function cpu_restore_state() isn't expected to be called in user-mode, as a consequence it isn't protected from race conditions. For information, syscalls are exceptions on Linux/SH4. There were two possible fixes: either "tb_loc