Re: [Qemu-devel] [PATCH] sheepdog: Fix misleading error messages in sd_snapshot_create()

2015-03-04 Thread Kevin Wolf
Am 12.02.2015 um 14:49 hat Markus Armbruster geschrieben: > If do_sd_create() fails, it first reports the error returned, then > reports a another one with strerror(errno). errno is meaningless at > that point. > > Report just one error combining the valid information from both > messages. > > R

Re: [Qemu-devel] [PATCH] sheepdog: Fix misleading error messages in sd_snapshot_create()

2015-02-27 Thread Markus Armbruster
Markus Armbruster writes: > If do_sd_create() fails, it first reports the error returned, then > reports a another one with strerror(errno). errno is meaningless at > that point. > > Report just one error combining the valid information from both > messages. > > Reported-by: Eric Blake > Signed

Re: [Qemu-devel] [PATCH] sheepdog: Fix misleading error messages in sd_snapshot_create()

2015-02-12 Thread Liu Yuan
On Thu, Feb 12, 2015 at 02:49:50PM +0100, Markus Armbruster wrote: > If do_sd_create() fails, it first reports the error returned, then > reports a another one with strerror(errno). errno is meaningless at > that point. > > Report just one error combining the valid information from both > message

Re: [Qemu-devel] [PATCH] sheepdog: Fix misleading error messages in sd_snapshot_create()

2015-02-12 Thread Eric Blake
On 02/12/2015 06:49 AM, Markus Armbruster wrote: > If do_sd_create() fails, it first reports the error returned, then > reports a another one with strerror(errno). errno is meaningless at > that point. > > Report just one error combining the valid information from both > messages. > > Reported-b

[Qemu-devel] [PATCH] sheepdog: Fix misleading error messages in sd_snapshot_create()

2015-02-12 Thread Markus Armbruster
If do_sd_create() fails, it first reports the error returned, then reports a another one with strerror(errno). errno is meaningless at that point. Report just one error combining the valid information from both messages. Reported-by: Eric Blake Signed-off-by: Markus Armbruster --- Applies on t