Re: [Qemu-devel] [PATCH] sheepdog: implement SD_OP_FLUSH_VDI operation

2012-04-23 Thread Christoph Hellwig
On Tue, Apr 24, 2012 at 01:26:43AM +0900, MORITA Kazutaka wrote: > SD_FLAG_CMD_CACHE is ignored in the older version of Sheepdog, so, > even if we specify cache=writeback or cache=none, the data is written > with O_DSYNC always and cannot be cached in the server's page cache or > volatile disk cach

Re: [Qemu-devel] [PATCH] sheepdog: implement SD_OP_FLUSH_VDI operation

2012-04-23 Thread MORITA Kazutaka
At Mon, 23 Apr 2012 08:08:46 +0200, Christoph Hellwig wrote: > > On Fri, Apr 20, 2012 at 12:15:36PM -0700, MORITA Kazutaka wrote: > > His patch sets the SD_FLAG_CMD_CACHE flag for writes only when the > > user selects cache=writeback or cache=none. If SD_FLAG_CMD_CACHE is > > not set in the reque

Re: [Qemu-devel] [PATCH] sheepdog: implement SD_OP_FLUSH_VDI operation

2012-04-22 Thread Christoph Hellwig
On Fri, Apr 20, 2012 at 12:15:36PM -0700, MORITA Kazutaka wrote: > His patch sets the SD_FLAG_CMD_CACHE flag for writes only when the > user selects cache=writeback or cache=none. If SD_FLAG_CMD_CACHE is > not set in the request, Sheepdog servers are forced to flush the cache > like FUA commands.

Re: [Qemu-devel] [PATCH] sheepdog: implement SD_OP_FLUSH_VDI operation

2012-04-20 Thread MORITA Kazutaka
At Fri, 20 Apr 2012 20:05:48 +0200, Christoph Hellwig wrote: > > On Tue, Apr 03, 2012 at 01:35:50AM +0800, Liu Yuan wrote: > > From: Liu Yuan > > > > Flush operation is supposed to flush the write-back cache of > > sheepdog cluster. > > > > By issuing flush operation, we can assure the Guest of

Re: [Qemu-devel] [PATCH] sheepdog: implement SD_OP_FLUSH_VDI operation

2012-04-20 Thread Christoph Hellwig
On Tue, Apr 03, 2012 at 01:35:50AM +0800, Liu Yuan wrote: > From: Liu Yuan > > Flush operation is supposed to flush the write-back cache of > sheepdog cluster. > > By issuing flush operation, we can assure the Guest of data > reaching the sheepdog cluster storage. How does qemu know that the ca

Re: [Qemu-devel] [PATCH] sheepdog: implement SD_OP_FLUSH_VDI operation

2012-04-02 Thread Liu Yuan
On 04/03/2012 04:01 AM, Michael Tokarev wrote: > On 02.04.2012 21:35, Liu Yuan wrote: >> From: Liu Yuan >> >> Flush operation is supposed to flush the write-back cache of >> sheepdog cluster. >> >> By issuing flush operation, we can assure the Guest of data >> reaching the sheepdog cluster storag

Re: [Qemu-devel] [PATCH] sheepdog: implement SD_OP_FLUSH_VDI operation

2012-04-02 Thread Michael Tokarev
On 02.04.2012 21:35, Liu Yuan wrote: > From: Liu Yuan > > Flush operation is supposed to flush the write-back cache of > sheepdog cluster. > > By issuing flush operation, we can assure the Guest of data > reaching the sheepdog cluster storage. > > Cc: Kevin Wolf > Reviewd-by: MORITA Kazutaka

[Qemu-devel] [PATCH] sheepdog: implement SD_OP_FLUSH_VDI operation

2012-04-02 Thread Liu Yuan
From: Liu Yuan Flush operation is supposed to flush the write-back cache of sheepdog cluster. By issuing flush operation, we can assure the Guest of data reaching the sheepdog cluster storage. Cc: Kevin Wolf Reviewd-by: MORITA Kazutaka Signed-off-by: Liu Yuan --- block/sheepdog.c | 50 +++