Re: [Qemu-devel] [PATCH] slirp: Enable fork_exec support on Windows

2018-11-26 Thread Philippe Mathieu-Daudé
Hi Samuel, On 20/11/18 1:57, Samuel Thibault wrote: > g_spawn_async_with_fds is portable on Windows, so we can now enable > fork_exec support there. > > Thanks Daniel P. Berrangé for the notice! On x86_64 you can build locally using Docker: $ make docker-test-build@debian-win32-cross BUILD

Re: [Qemu-devel] [PATCH] slirp: Enable fork_exec support on Windows

2018-11-20 Thread Daniel P . Berrangé
On Tue, Nov 20, 2018 at 01:57:01AM +0100, Samuel Thibault wrote: > g_spawn_async_with_fds is portable on Windows, so we can now enable > fork_exec support there. > > Thanks Daniel P. Berrangé for the notice! > > Signed-off-by: Samuel Thibault > --- > slirp/misc.c | 14 ++ > 1 file c

Re: [Qemu-devel] [PATCH] slirp: Enable fork_exec support on Windows

2018-11-19 Thread Marc-André Lureau
Hi On Tue, Nov 20, 2018 at 4:57 AM Samuel Thibault wrote: > > g_spawn_async_with_fds is portable on Windows, so we can now enable > fork_exec support there. > > Thanks Daniel P. Berrangé for the notice! > > Signed-off-by: Samuel Thibault Reviewed-by: Marc-André Lureau > --- > slirp/misc.c |

[Qemu-devel] [PATCH] slirp: Enable fork_exec support on Windows

2018-11-19 Thread Samuel Thibault
g_spawn_async_with_fds is portable on Windows, so we can now enable fork_exec support there. Thanks Daniel P. Berrangé for the notice! Signed-off-by: Samuel Thibault --- slirp/misc.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/slirp/misc.c b/slirp/misc.c