Re: [Qemu-devel] [PATCH] slirp: Fix build with gcc 9

2019-02-28 Thread Samuel Thibault
Hello, Peter Maydell, le jeu. 28 févr. 2019 18:14:40 +, a ecrit: > My guess is that this got a packed attribute mistakenly > by analogy with the struct slirp_arphdr which is used in > the ArpTable struct -- but that struct really is used to > match on-the-wire data, and this one is not. This

Re: [Qemu-devel] [PATCH] slirp: Fix build with gcc 9

2019-02-28 Thread Peter Maydell
On Thu, 28 Feb 2019 at 17:55, Greg Kurz wrote: > > Build fails with gcc 9: > > CC slirp/ndp_table.o > slirp/ndp_table.c: In function ‘ndp_table_add’: > slirp/ndp_table.c:31:23: error: taking address of packed member of ‘struct > ndpentry’ may result in an unaligned pointer value >

[Qemu-devel] [PATCH] slirp: Fix build with gcc 9

2019-02-28 Thread Greg Kurz
Build fails with gcc 9: CC slirp/ndp_table.o slirp/ndp_table.c: In function ‘ndp_table_add’: slirp/ndp_table.c:31:23: error: taking address of packed member of ‘struct ndpentry’ may result in an unaligned pointer value [-Werror=address-of-packed-member] 31 | if