Re: [Qemu-devel] [PATCH] slirp: Use lduw_be_p in slirp_input

2019-01-23 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20181226034254.17842-1-richard.hender...@linaro.org/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT

Re: [Qemu-devel] [PATCH] slirp: Use lduw_be_p in slirp_input

2019-01-18 Thread Peter Maydell
On Fri, 18 Jan 2019 at 11:37, Marc-André Lureau wrote: > The GStreamer solution is also quite readable. > https://gitlab.freedesktop.org/gstreamer/gstreamer/blob/master/gst/gstutils.h#L165 It has the disadvantage that you can never legitimately set GST_HAVE_UNALIGNED_ACCESS (because it is always

Re: [Qemu-devel] [PATCH] slirp: Use lduw_be_p in slirp_input

2019-01-18 Thread Marc-André Lureau
Hi On Fri, Jan 18, 2019 at 3:25 PM Marc-André Lureau wrote: > > Hi > > On Thu, Jan 17, 2019 at 5:56 PM Peter Maydell > wrote: > > > > On Thu, 17 Jan 2019 at 13:41, Philippe Mathieu-Daudé > > wrote: > > > On 1/17/19 12:50 AM, Samuel Thibault wrote: > > > > --- a/slirp/slirp.c > > > > +++ b/sli

Re: [Qemu-devel] [PATCH] slirp: Use lduw_be_p in slirp_input

2019-01-18 Thread Marc-André Lureau
Hi On Thu, Jan 17, 2019 at 5:56 PM Peter Maydell wrote: > > On Thu, 17 Jan 2019 at 13:41, Philippe Mathieu-Daudé > wrote: > > On 1/17/19 12:50 AM, Samuel Thibault wrote: > > > --- a/slirp/slirp.c > > > +++ b/slirp/slirp.c > > > @@ -851,7 +851,7 @@ void slirp_input(Slirp *slirp, const uint8_t *p

Re: [Qemu-devel] [PATCH] slirp: Use lduw_be_p in slirp_input

2019-01-17 Thread Peter Maydell
On Thu, 17 Jan 2019 at 13:41, Philippe Mathieu-Daudé wrote: > On 1/17/19 12:50 AM, Samuel Thibault wrote: > > --- a/slirp/slirp.c > > +++ b/slirp/slirp.c > > @@ -851,7 +851,7 @@ void slirp_input(Slirp *slirp, const uint8_t *pkt, int > > pkt_len) > > if (pkt_len < ETH_HLEN) > > retur

Re: [Qemu-devel] [PATCH] slirp: Use lduw_be_p in slirp_input

2019-01-17 Thread Samuel Thibault
Philippe Mathieu-Daudé, le jeu. 17 janv. 2019 14:16:16 +0100, a ecrit: > On 1/17/19 12:50 AM, Samuel Thibault wrote: > > Hello, > > > > Richard Henderson, le mer. 26 déc. 2018 14:42:54 +1100, a ecrit: > >> The pointer may be unaligned, so we must use our routines for that. > >> At the same time, w

Re: [Qemu-devel] [PATCH] slirp: Use lduw_be_p in slirp_input

2019-01-17 Thread Philippe Mathieu-Daudé
On 1/17/19 12:50 AM, Samuel Thibault wrote: > Hello, > > Richard Henderson, le mer. 26 déc. 2018 14:42:54 +1100, a ecrit: >> The pointer may be unaligned, so we must use our routines for that. >> At the same time, we might as well use the big-endian version >> instead of ntohs. >> >> This fixes sp

Re: [Qemu-devel] [PATCH] slirp: Use lduw_be_p in slirp_input

2019-01-16 Thread Richard Henderson
On 1/17/19 10:50 AM, Samuel Thibault wrote: > Hello, > > Richard Henderson, le mer. 26 déc. 2018 14:42:54 +1100, a ecrit: >> The pointer may be unaligned, so we must use our routines for that. >> At the same time, we might as well use the big-endian version >> instead of ntohs. >> >> This fixes sp

Re: [Qemu-devel] [PATCH] slirp: Use lduw_be_p in slirp_input

2019-01-16 Thread Samuel Thibault
Hello, Richard Henderson, le mer. 26 déc. 2018 14:42:54 +1100, a ecrit: > The pointer may be unaligned, so we must use our routines for that. > At the same time, we might as well use the big-endian version > instead of ntohs. > > This fixes sparc64 host SIGBUS during pxe boot. I'm not at ease wi

Re: [Qemu-devel] [PATCH] slirp: Use lduw_be_p in slirp_input

2018-12-26 Thread Philippe Mathieu-Daudé
Le mer. 26 déc. 2018 04:43, Richard Henderson a écrit : > The pointer may be unaligned, so we must use our routines for that. > At the same time, we might as well use the big-endian version > instead of ntohs. > > This fixes sparc64 host SIGBUS during pxe boot. > > Signed-off-by: Richard Henderso

Re: [Qemu-devel] [PATCH] slirp: Use lduw_be_p in slirp_input

2018-12-26 Thread Peter Maydell
On Wed, 26 Dec 2018 at 03:44, Richard Henderson wrote: > > The pointer may be unaligned, so we must use our routines for that. > At the same time, we might as well use the big-endian version > instead of ntohs. > > This fixes sparc64 host SIGBUS during pxe boot. > > Signed-off-by: Richard Henderso

[Qemu-devel] [PATCH] slirp: Use lduw_be_p in slirp_input

2018-12-25 Thread Richard Henderson
The pointer may be unaligned, so we must use our routines for that. At the same time, we might as well use the big-endian version instead of ntohs. This fixes sparc64 host SIGBUS during pxe boot. Signed-off-by: Richard Henderson --- slirp/slirp.c | 2 +- 1 file changed, 1 insertion(+), 1 deleti