Hi Phil,
William: How did you notice that? Using a static analyzer?
It was while looking into a previous CVE in tcp_emu, just with a manual
code review.
We have a data leak, Cc'ing qemu-stable.
> (Adding the address I noticed you Cc'ed secal...@redhat.com, so that
> confirms my guess).
Yeah
Hello,
Philippe Mathieu-Daudé, le sam. 02 mars 2019 18:42:42 +0100, a ecrit:
> Samuel: since this diff is not obvious without looking at the context
> (also due to the code re-indent),
I dropped the code re-indent to make the change obvious. I still added
the commit description, always better
Hi William, Samuel,
On 3/1/19 10:45 PM, William Bowling wrote:
> When emulating ident in tcp_emu, if the strchr checks passed but the
> sscanf check failed, two uninitialized variables would be copied and
> sent in the reply.
William: How did you notice that? Using a static analyzer?
Samuel:
William Bowling, le ven. 01 mars 2019 21:45:56 +, a ecrit:
> When emulating ident in tcp_emu, if the strchr checks passed but the
> sscanf check failed, two uninitialized variables would be copied and
> sent in the reply.
>
> Signed-off-by: William Bowling
Applied to my tree, thanks!
> ---
When emulating ident in tcp_emu, if the strchr checks passed but the
sscanf check failed, two uninitialized variables would be copied and
sent in the reply.
Signed-off-by: William Bowling
---
slirp/tcp_subr.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git
