Re: [Qemu-devel] [PATCH] slirp: disable Nagle in outgoing connections

2018-03-07 Thread Samuel Thibault
Philippe Mathieu-Daudé, on mer. 07 mars 2018 19:57:28 -0300, wrote: > Reviewed-by: Philippe Mathieu-Daudé Thanks!

Re: [Qemu-devel] [PATCH] slirp: disable Nagle in outgoing connections

2018-03-07 Thread Philippe Mathieu-Daudé
On 03/07/2018 07:34 PM, Samuel Thibault wrote: > Hello, > > Thanks for the Cc. > > I have applied it to my tree. I don't think there is any reason to > avoid the same change for ingoing connections? Could one of your review > the attached patch doing it? attached patch: Reviewed-by: Philippe

Re: [Qemu-devel] [PATCH] slirp: disable Nagle in outgoing connections

2018-03-07 Thread Samuel Thibault
Hello, Thanks for the Cc. I have applied it to my tree. I don't think there is any reason to avoid the same change for ingoing connections? Could one of your review the attached patch doing it? Samuel commit 99a9a5028e0e15aa3b17d6f884c1e5f48dccea90 Author: Samuel Thibault

Re: [Qemu-devel] [PATCH] slirp: disable Nagle in outgoing connections

2018-03-07 Thread Kamil Rytarowski
On 07.03.2018 10:38, Philippe Mathieu-Daudé wrote: > On 03/07/2018 06:13 AM, Kamil Rytarowski wrote: >> This patch is correct. LLDB expects 1sec for reply, GDB by default 2. >> >> Debuggers use this option to disable Nagle algorithm in order to quickly >> transfer messages between gdb-server and

Re: [Qemu-devel] [PATCH] slirp: disable Nagle in outgoing connections

2018-03-07 Thread Philippe Mathieu-Daudé
On 03/07/2018 06:13 AM, Kamil Rytarowski wrote: > This patch is correct. LLDB expects 1sec for reply, GDB by default 2. > > Debuggers use this option to disable Nagle algorithm in order to quickly > transfer messages between gdb-server and gdb-client. It's also fairy > portable across systems. >

Re: [Qemu-devel] [PATCH] slirp: disable Nagle in outgoing connections

2018-03-07 Thread Kamil Rytarowski
This patch is correct. LLDB expects 1sec for reply, GDB by default 2. Debuggers use this option to disable Nagle algorithm in order to quickly transfer messages between gdb-server and gdb-client. It's also fairy portable across systems. On 04.01.2018 18:56, Andreas Gustafsson wrote: > slirp:

[Qemu-devel] [PATCH] slirp: disable Nagle in outgoing connections

2018-01-04 Thread Andreas Gustafsson
slirp: disable Nagle in outgoing connections When setting up an outgoing user mode networking TCP connection, disable the Nagle algorithm in the host-side connection. Either the guest is already doing Nagle, in which case there is no point in doing it twice, or it has chosen to disable it, in