Re: [Qemu-devel] [PATCH] slirp: fix clearing ifq_so from pending packets

2017-08-30 Thread Peter Maydell
On 30 August 2017 at 08:52, Samuel Thibault wrote: > Thomas Huth, on mer. 30 août 2017 09:50:45 +0200, wrote: >> On 26.08.2017 00:37, Samuel Thibault wrote: >> > The if_fastq and if_batchq contain not only packets, but queues of packets >> > for the same socket. When sofree frees a socket, it thus

Re: [Qemu-devel] [PATCH] slirp: fix clearing ifq_so from pending packets

2017-08-30 Thread Samuel Thibault
Thomas Huth, on mer. 30 août 2017 09:50:45 +0200, wrote: > On 26.08.2017 00:37, Samuel Thibault wrote: > > The if_fastq and if_batchq contain not only packets, but queues of packets > > for the same socket. When sofree frees a socket, it thus has to clear ifq_so > > from all the packets from the qu

Re: [Qemu-devel] [PATCH] slirp: fix clearing ifq_so from pending packets

2017-08-30 Thread Thomas Huth
Hi Samuel, On 26.08.2017 00:37, Samuel Thibault wrote: > The if_fastq and if_batchq contain not only packets, but queues of packets > for the same socket. When sofree frees a socket, it thus has to clear ifq_so > from all the packets from the queues, not only the first. I think you should CC: th

Re: [Qemu-devel] [PATCH] slirp: fix clearing ifq_so from pending packets

2017-08-28 Thread P J P
Hello Samuel, +-- On Sat, 26 Aug 2017, Samuel Thibault wrote --+ | So Wjjzhang and PJP, can you confirm that this fixes your uses? Yes, I confirm the patch fixes the use-after-free issue. Thank you so much. -- Prasad J Pandit / Red Hat Product Security Team 47AF CE69 3A90 54AA 9045 1053 DD13 3

Re: [Qemu-devel] [PATCH] slirp: fix clearing ifq_so from pending packets

2017-08-25 Thread Samuel Thibault
Samuel Thibault, on sam. 26 août 2017 01:05:04 +0200, wrote: > So Wjjzhang and PJP, can you confirm that this fixes your uses? PJP, can you forward it to Wjjzhang? I keep getting : host cloudmx.qq.com[113.108.11.188] said: 550 Mail content denied. http://ascloud.qq.com/cgi-bin/readtempla

Re: [Qemu-devel] [PATCH] slirp: fix clearing ifq_so from pending packets

2017-08-25 Thread Samuel Thibault
Hello, So Wjjzhang and PJP, can you confirm that this fixes your uses? Samuel Samuel Thibault, on sam. 26 août 2017 00:37:21 +0200, wrote: > The if_fastq and if_batchq contain not only packets, but queues of packets > for the same socket. When sofree frees a socket, it thus has to clear ifq_so >

Re: [Qemu-devel] [PATCH] slirp: fix clearing ifq_so from pending packets

2017-08-25 Thread Philippe Mathieu-Daudé
Hi Sam, thanks for this patch :) On 08/25/2017 07:37 PM, Samuel Thibault wrote: The if_fastq and if_batchq contain not only packets, but queues of packets for the same socket. When sofree frees a socket, it thus has to clear ifq_so from all the packets from the queues, not only the first. Signe

[Qemu-devel] [PATCH] slirp: fix clearing ifq_so from pending packets

2017-08-25 Thread Samuel Thibault
The if_fastq and if_batchq contain not only packets, but queues of packets for the same socket. When sofree frees a socket, it thus has to clear ifq_so from all the packets from the queues, not only the first. Signed-off-by: Samuel Thibault Acked-by: Philippe Mathieu-Daudé --- slirp/socket.c |