Re: [Qemu-devel] [PATCH] slirp: support dynamic block size for TFTP transfers

2016-12-20 Thread Samuel Thibault
Hervé Poussineau, on Mon 21 Nov 2016 20:45:49 +0100, wrote: > The blocksize option is defined in RFC 1783. > We now support block sizes between 1 and 1432 bytes, instead of 512 only. > > Signed-off-by: Hervé Poussineau I fixed a couple of trivial things and commited to my tree, thanks! Samuel

Re: [Qemu-devel] [PATCH] slirp: support dynamic block size for TFTP transfers

2016-11-22 Thread Thomas Huth
On 21.11.2016 20:51, H. Peter Anvin wrote: > On 11/21/16 11:45, Hervé Poussineau wrote: >> The blocksize option is defined in RFC 1783. >> We now support block sizes between 1 and 1432 bytes, instead of 512 only. > > It ought to be 1476: Ethernet MTU = 1500, minus a minimum of 20 bytes > for an IP

Re: [Qemu-devel] [PATCH] slirp: support dynamic block size for TFTP transfers

2016-11-21 Thread H. Peter Anvin
On 11/21/16 11:45, Hervé Poussineau wrote: > The blocksize option is defined in RFC 1783. > We now support block sizes between 1 and 1432 bytes, instead of 512 only. It ought to be 1476: Ethernet MTU = 1500, minus a minimum of 20 bytes for an IPv4 header and 4 for a TFTP header. Some bootloaders

Re: [Qemu-devel] [PATCH] slirp: support dynamic block size for TFTP transfers

2016-11-21 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] slirp: support dynamic block size for TFTP transfers Type: series Message-id: 1479757549-18672-1-git-send-email-hpous...@reactos.org === TEST SCRIPT BEGIN === #!/bin

[Qemu-devel] [PATCH] slirp: support dynamic block size for TFTP transfers

2016-11-21 Thread Hervé Poussineau
The blocksize option is defined in RFC 1783. We now support block sizes between 1 and 1432 bytes, instead of 512 only. Signed-off-by: Hervé Poussineau --- slirp/tftp.c | 26 ++ slirp/tftp.h | 8 +--- 2 files changed, 19 insertions(+), 15 deletions(-) diff --git a/sl