Re: [Qemu-devel] [PATCH] spapr: fix xics_system_init() error path

2018-06-17 Thread David Gibson
On Fri, Jun 15, 2018 at 06:58:00PM +0200, Greg Kurz wrote: > Commit 3d85885a1b1f3 tried to fix error handling, but it actually > went into the wrong direction by dropping the local Error *. > > In the default KVM case, the rationale is to try the in-kernel XICS first, > and if not possible, to

[Qemu-devel] [PATCH] spapr: fix xics_system_init() error path

2018-06-15 Thread Greg Kurz
Commit 3d85885a1b1f3 tried to fix error handling, but it actually went into the wrong direction by dropping the local Error *. In the default KVM case, the rationale is to try the in-kernel XICS first, and if not possible, to fallback to userland XICS. Passing errp everywhere makes this fallback