Re: [Qemu-devel] [PATCH] spapr_cpu_core: instantiate CPUs separately

2017-11-06 Thread David Gibson
On Mon, Nov 06, 2017 at 04:03:07PM +0100, Greg Kurz wrote: > On Tue, 17 Oct 2017 17:16:09 +1100 > David Gibson wrote: > > > On Mon, Oct 16, 2017 at 10:26:38AM +0200, Igor Mammedov wrote: > > > On Sat, 14 Oct 2017 20:33:37 +1100 > > > David Gibson

Re: [Qemu-devel] [PATCH] spapr_cpu_core: instantiate CPUs separately

2017-11-06 Thread Greg Kurz
On Tue, 17 Oct 2017 17:16:09 +1100 David Gibson wrote: > On Mon, Oct 16, 2017 at 10:26:38AM +0200, Igor Mammedov wrote: > > On Sat, 14 Oct 2017 20:33:37 +1100 > > David Gibson wrote: > > > > > On Fri, Oct 13, 2017 at 01:31:44PM +0200,

Re: [Qemu-devel] [PATCH] spapr_cpu_core: instantiate CPUs separately

2017-10-17 Thread David Gibson
On Mon, Oct 16, 2017 at 10:26:38AM +0200, Igor Mammedov wrote: > On Sat, 14 Oct 2017 20:33:37 +1100 > David Gibson wrote: > > > On Fri, Oct 13, 2017 at 01:31:44PM +0200, Greg Kurz wrote: > > > The current code assumes that only the CPU core object holds a > > >

Re: [Qemu-devel] [PATCH] spapr_cpu_core: instantiate CPUs separately

2017-10-16 Thread Igor Mammedov
On Sat, 14 Oct 2017 20:33:37 +1100 David Gibson wrote: > On Fri, Oct 13, 2017 at 01:31:44PM +0200, Greg Kurz wrote: > > The current code assumes that only the CPU core object holds a > > reference on each individual CPU object, and happily frees their > > allocated

Re: [Qemu-devel] [PATCH] spapr_cpu_core: instantiate CPUs separately

2017-10-15 Thread Greg Kurz
On Sat, 14 Oct 2017 20:33:37 +1100 David Gibson wrote: > On Fri, Oct 13, 2017 at 01:31:44PM +0200, Greg Kurz wrote: > > The current code assumes that only the CPU core object holds a > > reference on each individual CPU object, and happily frees their > > allocated

Re: [Qemu-devel] [PATCH] spapr_cpu_core: instantiate CPUs separately

2017-10-14 Thread David Gibson
On Fri, Oct 13, 2017 at 01:31:44PM +0200, Greg Kurz wrote: > The current code assumes that only the CPU core object holds a > reference on each individual CPU object, and happily frees their > allocated memory when the core is unrealized. This is dangerous > as some other code can legitimely keep

[Qemu-devel] [PATCH] spapr_cpu_core: instantiate CPUs separately

2017-10-13 Thread Greg Kurz
The current code assumes that only the CPU core object holds a reference on each individual CPU object, and happily frees their allocated memory when the core is unrealized. This is dangerous as some other code can legitimely keep a pointer to a CPU if it calls object_ref(), but it would end up