[Qemu-devel] [PATCH] spice: fix 32bit build

2014-06-20 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/display/qxl.c | 2 +- ui/spice-display.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/display/qxl.c b/hw/display/qxl.c index 736fd3c..d43aa49 100644 --- a/hw/display/qxl.c +++ b/hw/display/qxl.c @@ -710,7 +710,7

Re: [Qemu-devel] [PATCH] spice: fix 32bit build

2014-06-20 Thread Luiz Capitulino
On Fri, 20 Jun 2014 08:12:44 +0200 Gerd Hoffmann kra...@redhat.com wrote: Signed-off-by: Gerd Hoffmann kra...@redhat.com Tested-by: Luiz Capitulino lcapitul...@redhat.com --- hw/display/qxl.c | 2 +- ui/spice-display.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff

Re: [Qemu-devel] [PATCH] spice: fix 32bit build

2014-06-20 Thread Peter Maydell
On 20 June 2014 14:35, Luiz Capitulino lcapitul...@redhat.com wrote: On Fri, 20 Jun 2014 08:12:44 +0200 Gerd Hoffmann kra...@redhat.com wrote: Signed-off-by: Gerd Hoffmann kra...@redhat.com Tested-by: Luiz Capitulino lcapitul...@redhat.com Thanks; applied directly to master as a buildfix.

Re: [Qemu-devel] [PATCH] spice: fix 32bit build

2014-06-20 Thread Luiz Capitulino
On Fri, 20 Jun 2014 16:57:11 +0100 Peter Maydell peter.mayd...@linaro.org wrote: On 20 June 2014 14:35, Luiz Capitulino lcapitul...@redhat.com wrote: On Fri, 20 Jun 2014 08:12:44 +0200 Gerd Hoffmann kra...@redhat.com wrote: Signed-off-by: Gerd Hoffmann kra...@redhat.com Tested-by:

[Qemu-devel] [PATCH] spice: fix 32bit build

2012-03-20 Thread Gerd Hoffmann
New 32bit warnings sneaked in, this time in ui/spice-display.c, fix them. This gets annonying, /me sets up a ubuntu buildbot slave for 32bit spice testbuilds. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- roms/seabios |2 +- ui/spice-display.c | 12 ++-- 2 files

Re: [Qemu-devel] [PATCH] spice: fix 32bit build

2012-03-20 Thread Peter Maydell
On 20 March 2012 11:26, Gerd Hoffmann kra...@redhat.com wrote: New 32bit warnings sneaked in, this time in ui/spice-display.c, fix them. This gets annonying, /me sets up a ubuntu buildbot slave for 32bit spice testbuilds. Signed-off-by: Gerd Hoffmann kra...@redhat.com ---  roms/seabios    

Re: [Qemu-devel] [PATCH] spice: fix 32bit build

2012-03-20 Thread Gerd Hoffmann
Hi, What's the roms/seabios change doing here? Just a missing git submodule update and the diff from that sneaking in. Also, isn't the ui/spice-display.c patch the same as this one from me from a couple of weeks back? http://patchwork.ozlabs.org/patch/145269/ It is. Picked that one up

Re: [Qemu-devel] [PATCH] spice: fix 32bit build

2012-03-20 Thread Peter Maydell
On 20 March 2012 12:13, Gerd Hoffmann kra...@redhat.com wrote: Also, isn't the ui/spice-display.c patch the same as this one from me from a couple of weeks back? http://patchwork.ozlabs.org/patch/145269/ It is.  Picked that one up instead. /me is confused, I through I had that one already

Re: [Qemu-devel] [PATCH] spice: fix 32bit build

2012-03-20 Thread Michael Tokarev
20.03.2012 15:26, Gerd Hoffmann wrote: New 32bit warnings sneaked in, this time in ui/spice-display.c, fix them. This gets annonying, /me sets up a ubuntu buildbot slave for 32bit spice testbuilds. Um, is it worth to watch/fix? Note that spice does not work on 32bits anyway, qemu segfaults

Re: [Qemu-devel] [PATCH] spice: fix 32bit build

2012-03-20 Thread Alon Levy
On Tue, Mar 20, 2012 at 04:45:26PM +0400, Michael Tokarev wrote: 20.03.2012 15:26, Gerd Hoffmann wrote: New 32bit warnings sneaked in, this time in ui/spice-display.c, fix them. This gets annonying, /me sets up a ubuntu buildbot slave for 32bit spice testbuilds. Um, is it worth to

Re: [Qemu-devel] [PATCH] spice: fix 32bit build

2012-03-20 Thread Peter Maydell
On 20 March 2012 12:45, Michael Tokarev m...@tls.msk.ru wrote: Um, is it worth to watch/fix?  Note that spice does not work on 32bits anyway, qemu segfaults at startup... I've had conflicting answers about this -- the Spice FAQ says it doesn't work on 32 bits but in this message: