Re: [Qemu-devel] [PATCH] sun4u: add power_mem_read routine

2019-01-07 Thread Mark Cave-Ayland
On 04/01/2019 09:53, P J P wrote: > +-- On Fri, 4 Jan 2019, Mark Cave-Ayland wrote --+ > | I asked someone with real Ultra-5 hardware to check this for me, and > they've > | sent me back the following output: > | > | ok .properties > | address fffb8000 > | button > | interrupts

Re: [Qemu-devel] [PATCH] sun4u: add power_mem_read routine

2019-01-04 Thread Philippe Mathieu-Daudé
Le ven. 4 janv. 2019 10:55, P J P a écrit : > +-- On Fri, 4 Jan 2019, Mark Cave-Ayland wrote --+ > | I asked someone with real Ultra-5 hardware to check this for me, and > they've > | sent me back the following output: > | > | ok .properties > | address fffb8000 > | button > | in

Re: [Qemu-devel] [PATCH] sun4u: add power_mem_read routine

2019-01-04 Thread P J P
+-- On Fri, 4 Jan 2019, Mark Cave-Ayland wrote --+ | I asked someone with real Ultra-5 hardware to check this for me, and they've | sent me back the following output: | | ok .properties | address fffb8000 | button | interrupts 0001 | reg 000

Re: [Qemu-devel] [PATCH] sun4u: add power_mem_read routine

2019-01-04 Thread Mark Cave-Ayland
On 04/01/2019 05:47, P J P wrote: > Hello Mark, > > +-- On Thu, 3 Jan 2019, Mark Cave-Ayland wrote --+ > | > /* Power */ > | > +static uint64_t power_mem_read(void *opaque, hwaddr addr, unsigned size) > | > +{ > | > +return 0x; > | > +} > | > + > | > > | > static const MemoryReg

Re: [Qemu-devel] [PATCH] sun4u: add power_mem_read routine

2019-01-03 Thread P J P
Hello Mark, +-- On Thu, 3 Jan 2019, Mark Cave-Ayland wrote --+ | > /* Power */ | > +static uint64_t power_mem_read(void *opaque, hwaddr addr, unsigned size) | > +{ | > +return 0x; | > +} | > + | > | > static const MemoryRegionOps power_mem_ops = { | > +.read = power_mem_read,

Re: [Qemu-devel] [PATCH] sun4u: add power_mem_read routine

2019-01-03 Thread Mark Cave-Ayland
On 03/01/2019 09:37, P J P wrote: > From: Prasad J Pandit > > Define skeleton 'power_mem_read' routine. Avoid NULL dereference. > > Reported-by: Fakhri Zulkifli > Signed-off-by: Prasad J Pandit > --- > hw/sparc64/sun4u.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/hw/spar

[Qemu-devel] [PATCH] sun4u: add power_mem_read routine

2019-01-03 Thread P J P
From: Prasad J Pandit Define skeleton 'power_mem_read' routine. Avoid NULL dereference. Reported-by: Fakhri Zulkifli Signed-off-by: Prasad J Pandit --- hw/sparc64/sun4u.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/sparc64/sun4u.c b/hw/sparc64/sun4u.c index f76b19e4e9..cbdb2b