Re: [Qemu-devel] [PATCH] syscall: fixed mincore(2) not failing with ENOMEM

2017-02-27 Thread Michael Tokarev
16.02.2017 11:58, Franklin Snaipe Mathieu wrote: > From: "Franklin \"Snaipe\" Mathieu" > > The current implementation of the mincore(2) syscall sets errno to > EFAULT when the region identified by the first two parameters is > invalid. > > This goes against the man page specification, where minc

Re: [Qemu-devel] [PATCH] syscall: fixed mincore(2) not failing with ENOMEM

2017-02-17 Thread Fam Zheng
On Fri, 02/17 09:00, Franklin "Snaipe" Mathieu wrote: > Ignore this patch, this was sent again by mistake. Hi Franklin, thanks for the re-submission. Next time please send consecutive versions as top-level threads instead of replies to previous versions, with proper 'v2", "v3" tags in the subject.

[Qemu-devel] [PATCH] syscall: fixed mincore(2) not failing with ENOMEM

2017-02-17 Thread Franklin Snaipe Mathieu
From: "Franklin \"Snaipe\" Mathieu" The current implementation of the mincore(2) syscall sets errno to EFAULT when the region identified by the first two parameters is invalid. This goes against the man page specification, where mincore(2) should only fail with EFAULT when the third parameter is

Re: [Qemu-devel] [PATCH] syscall: fixed mincore(2) not failing with ENOMEM

2017-02-17 Thread Franklin "Snaipe" Mathieu
Ignore this patch, this was sent again by mistake. 2017-02-17 8:57 GMT+00:00 Franklin Snaipe Mathieu : > From: "Franklin \"Snaipe\" Mathieu" > > The current implementation of the mincore(2) syscall sets errno to > EFAULT when the region identified by the first two parameters is > invalid. > > Thi

Re: [Qemu-devel] [PATCH] syscall: fixed mincore(2) not failing with ENOMEM

2017-02-17 Thread Franklin "Snaipe" Mathieu
2017-02-17 0:50 GMT+00:00 Fam Zheng : > On Thu, 02/16 08:58, Franklin Snaipe Mathieu wrote: >> +p = lock_user_string(arg3) >> +if (!p) { > > Please compile test at least, even if it is a trivial patch. > Whoops, sorry, I forgot to re-compile after fixing the checkpatch issu

Re: [Qemu-devel] [PATCH] syscall: fixed mincore(2) not failing with ENOMEM

2017-02-16 Thread Fam Zheng
On Thu, 02/16 08:58, Franklin Snaipe Mathieu wrote: > +p = lock_user_string(arg3) > +if (!p) { Please compile test at least, even if it is a trivial patch. Fam

[Qemu-devel] [PATCH] syscall: fixed mincore(2) not failing with ENOMEM

2017-02-16 Thread Franklin Snaipe Mathieu
From: "Franklin \"Snaipe\" Mathieu" The current implementation of the mincore(2) syscall sets errno to EFAULT when the region identified by the first two parameters is invalid. This goes against the man page specification, where mincore(2) should only fail with EFAULT when the third parameter is