Re: [Qemu-devel] [PATCH] syscall.c: Fix build with older linux-headers

2016-08-16 Thread Laurent Vivier
Le 16/08/2016 à 19:31, Peter Maydell a écrit : > On 16 August 2016 at 18:28, Laurent Vivier wrote: >> >> >> Le 16/08/2016 à 18:51, Peter Maydell a écrit : >>> The best approach I can think of is to add something at the >>> top of syscall.c that does: >>> #if IFLA_BR_MAX < 9

Re: [Qemu-devel] [PATCH] syscall.c: Fix build with older linux-headers

2016-08-16 Thread Peter Maydell
On 16 August 2016 at 18:28, Laurent Vivier wrote: > > > Le 16/08/2016 à 18:51, Peter Maydell a écrit : >> The best approach I can think of is to add something at the >> top of syscall.c that does: >> #if IFLA_BR_MAX < 9 >> #define IFLA_BR_GROUP_FWD_MASK 9 >> #endif >> #if

Re: [Qemu-devel] [PATCH] syscall.c: Fix build with older linux-headers

2016-08-16 Thread Laurent Vivier
Le 16/08/2016 à 18:51, Peter Maydell a écrit : > On 16 August 2016 at 17:41, Laurent Vivier wrote: >> Le 16/08/2016 à 11:47, Michal Privoznik a écrit : >>> In c5dff280 we tried to make us understand netlink messages more. >>> So we've added a code that does some translation.

Re: [Qemu-devel] [PATCH] syscall.c: Fix build with older linux-headers

2016-08-16 Thread Michal Privoznik
On 16.08.2016 18:51, Peter Maydell wrote: > On 16 August 2016 at 17:41, Laurent Vivier wrote: >> Le 16/08/2016 à 11:47, Michal Privoznik a écrit : >>> In c5dff280 we tried to make us understand netlink messages more. >>> So we've added a code that does some translation.

Re: [Qemu-devel] [PATCH] syscall.c: Fix build with older linux-headers

2016-08-16 Thread Peter Maydell
On 16 August 2016 at 17:41, Laurent Vivier wrote: > Le 16/08/2016 à 11:47, Michal Privoznik a écrit : >> In c5dff280 we tried to make us understand netlink messages more. >> So we've added a code that does some translation. However, the >> code assumed linux-headers to be at

Re: [Qemu-devel] [PATCH] syscall.c: Fix build with older linux-headers

2016-08-16 Thread Laurent Vivier
Le 16/08/2016 à 11:47, Michal Privoznik a écrit : > In c5dff280 we tried to make us understand netlink messages more. > So we've added a code that does some translation. However, the > code assumed linux-headers to be at least version 4.4 of it > because most of the symbols there (if not all of

Re: [Qemu-devel] [PATCH] syscall.c: Fix build with older linux-headers

2016-08-16 Thread Peter Maydell
On 16 August 2016 at 10:47, Michal Privoznik wrote: > In c5dff280 we tried to make us understand netlink messages more. > So we've added a code that does some translation. However, the > code assumed linux-headers to be at least version 4.4 of it > because most of the symbols

Re: [Qemu-devel] [PATCH] syscall.c: Fix build with older linux-headers

2016-08-16 Thread Michal Privoznik
On 16.08.2016 12:04, Peter Maydell wrote: > On 16 August 2016 at 10:47, Michal Privoznik wrote: >> In c5dff280 we tried to make us understand netlink messages more. >> So we've added a code that does some translation. However, the >> code assumed linux-headers to be at least

Re: [Qemu-devel] [PATCH] syscall.c: Fix build with older linux-headers

2016-08-16 Thread Peter Maydell
On 16 August 2016 at 10:47, Michal Privoznik wrote: > In c5dff280 we tried to make us understand netlink messages more. > So we've added a code that does some translation. However, the > code assumed linux-headers to be at least version 4.4 of it > because most of the symbols

[Qemu-devel] [PATCH] syscall.c: Fix build with older linux-headers

2016-08-16 Thread Michal Privoznik
In c5dff280 we tried to make us understand netlink messages more. So we've added a code that does some translation. However, the code assumed linux-headers to be at least version 4.4 of it because most of the symbols there (if not all of them) were added in just that release. This, however, breaks