Re: [Qemu-devel] [PATCH] target/arm/vfp_helper: Call set_fpscr_to_host before updating to FPSCR

2019-07-05 Thread Laurent Desnogues
On Fri, Jul 5, 2019 at 2:43 PM Philippe Mathieu-Daudé wrote: > > In commit e9d652824b0 we extracted the vfp_set_fpscr_to_host() > function but failed at calling it in the correct place, we call > it after xregs[ARM_VFP_FPSCR] is modified. > > Fix by calling this function before we update FPSCR. >

Re: [Qemu-devel] [PATCH] target/arm/vfp_helper: Call set_fpscr_to_host before updating to FPSCR

2019-07-05 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Correct subject: "Call set_fpscr_to_host before updating FPSCR reg" > (or without "reg"). Queued to testing/next, thanks. > > On 7/5/19 2:43 PM, Philippe Mathieu-Daudé wrote: >> In commit e9d652824b0 we extracted the vfp_set_fpscr_to_host() >> function but

Re: [Qemu-devel] [PATCH] target/arm/vfp_helper: Call set_fpscr_to_host before updating to FPSCR

2019-07-05 Thread Philippe Mathieu-Daudé
Correct subject: "Call set_fpscr_to_host before updating FPSCR reg" (or without "reg"). On 7/5/19 2:43 PM, Philippe Mathieu-Daudé wrote: > In commit e9d652824b0 we extracted the vfp_set_fpscr_to_host() > function but failed at calling it in the correct place, we call > it after

[Qemu-devel] [PATCH] target/arm/vfp_helper: Call set_fpscr_to_host before updating to FPSCR

2019-07-05 Thread Philippe Mathieu-Daudé
In commit e9d652824b0 we extracted the vfp_set_fpscr_to_host() function but failed at calling it in the correct place, we call it after xregs[ARM_VFP_FPSCR] is modified. Fix by calling this function before we update FPSCR. Reported-by: Laurent Desnogues Signed-off-by: Philippe Mathieu-Daudé