Re: [Qemu-devel] [PATCH] target/arm: Add assertion about FSC format for syndrome registers

2017-04-10 Thread Peter Maydell
On 10 April 2017 at 09:44, Edgar E. Iglesias wrote: > Have you seen something suspicous when running code or was > this a theoretical issue? No, I was looking at the code for a different reason and was surprised that the syndrome-generation code wasn't doing anything to handle short-format FSRs.

Re: [Qemu-devel] [PATCH] target/arm: Add assertion about FSC format for syndrome registers

2017-04-10 Thread Edgar E. Iglesias
On Thu, Apr 06, 2017 at 02:42:32PM +0100, Peter Maydell wrote: > In tlb_fill() we construct a syndrome register value from a > fault status register value which is filled in by arm_tlb_fill(). > arm_tlb_fill() returns FSR values which might be in the format > used with short-format page descriptors

Re: [Qemu-devel] [PATCH] target/arm: Add assertion about FSC format for syndrome registers

2017-04-10 Thread Edgar E. Iglesias
On Thu, Apr 06, 2017 at 02:42:32PM +0100, Peter Maydell wrote: > In tlb_fill() we construct a syndrome register value from a > fault status register value which is filled in by arm_tlb_fill(). > arm_tlb_fill() returns FSR values which might be in the format > used with short-format page descriptors

[Qemu-devel] [PATCH] target/arm: Add assertion about FSC format for syndrome registers

2017-04-06 Thread Peter Maydell
In tlb_fill() we construct a syndrome register value from a fault status register value which is filled in by arm_tlb_fill(). arm_tlb_fill() returns FSR values which might be in the format used with short-format page descriptors, or the format used with long-format (LPAE) descriptors. The syndrome